Sidebar - #4
Open
kimocoder wants to merge 22 commits into
Open
Conversation
doesn't yet perisist across the whole app. This is because we should: (1) decide what goes in the navigation drawer vs. menus (2) stop loading activities and start loading in fragments (3) think about how to use fragments in a cool way.
will now use a drawer that will overlap the action bar, hiding the menu. It's just a PoC, there is much more work to do.
… object get deleted )
created a progress dialog that will show up only if a certain amount of time has been elapsed and disappear if has been shown for at least another certain time. show such progress dialog when changing interface ( stopping and starting network radar may require some second ). another way is to asynchronous stopping the network-radar but we should deregister receivers and we lost the STARTED/STOPPED intents. in a far future we will support more running instances of network-radar, so you can be notified ( say, with a small icon over the interface name ) that new hosts appearead on interfaces that you are not watching.
it may require some data not available in the contructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.