test: verify the node's transaction is valid to Core - #88
Merged
rustaceanrob merged 2 commits intoJul 25, 2026
Conversation
pzafonte
marked this pull request as draft
July 24, 2026 15:53
Fund a spend-capable node, have it build and broadcast a send to a Core address, and confirm Core accepts the node-built transaction into its mempool. Gives start_connected an optional keys argument and a random_signing_keys helper so the test can start a signing-capable node, and adds a helper that polls Core's mempool for the txid.
pzafonte
force-pushed
the
itest-tx-valid-to-core
branch
from
July 25, 2026 02:30
dea9203 to
6c087e2
Compare
Contributor
|
Looks good to me. Why is this in draft? |
Contributor
Author
I had it that way because the CI was red before. I'm debugging that issue today. |
pzafonte
marked this pull request as ready for review
July 25, 2026 12:38
4 tasks
rustaceanrob
approved these changes
Jul 25, 2026
rustaceanrob
left a comment
rustaceanrob
left a comment
Contributor
There was a problem hiding this comment.
lgtm thanks for closing the loop here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fund a spend-capable node, have it build and broadcast a send to a Core
address, and confirm Core accepts the node-built transaction into its
mempool. Gives
start_connectedan optional keys argument and arandom_signing_keyshelper so the test can start a signing-capablenode, and adds a helper that polls Core's mempool for the
txid.Adds a separate commit to verify the wallet imports keys over the CLI.