test: Verify the node tracks Bitcoin Core's chain - #86
Merged
Conversation
This was referenced Jul 19, 2026
Contributor
|
Needs rebase |
pzafonte
force-pushed
the
itest-chain-tracking
branch
from
July 20, 2026 17:24
8fc85d9 to
9f259ce
Compare
pzafonte
changed the title
pzafonte
changed the title
pzafonte
force-pushed
the
itest-chain-tracking
branch
from
July 20, 2026 17:27
9f259ce to
bcddd00
Compare
Contributor
Author
Rebased and changed some Temporarily stacking a commit to test the macOS runner. Will remove it later. |
pzafonte
force-pushed
the
itest-chain-tracking
branch
from
July 20, 2026 18:18
fb26e6a to
bcddd00
Compare
Contributor
Author
|
The intermittent macOS CI failure might be a shutdown race in the node. |
|
|
||
| pub fn tip(&self) -> (u32, bitcoin::BlockHash) { | ||
| let socket = self.socket_path(); | ||
| let rt = tokio::runtime::Builder::new_current_thread() |
Contributor
There was a problem hiding this comment.
Should we hold this runtime and initialize it once at TestNode startup? Seems like a non-negligible cost that might be avoidable.
Contributor
Author
There was a problem hiding this comment.
Good call, looks like it.
Contributor
Please open an issue whenever you are available with the debug details. Otherwise things are looking good here. |
Add two tests that drive the node against a regtest bitcoind through getTip. One mines blocks and waits for the node to reach the same tip. The other invalidates a block on Core and mines a longer competing branch, then waits for the node to reorg to it. The competing branch is mined to a fresh address so its blocks differ from the invalidated ones.
pzafonte
force-pushed
the
itest-chain-tracking
branch
from
July 20, 2026 20:36
bcddd00 to
ecf57a4
Compare
pzafonte
marked this pull request as ready for review
July 20, 2026 20:37
rustaceanrob
left a comment
rustaceanrob
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Tested a handful of times locally
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two tests that drive the node against a regtest
bitcoindthroughgetTip. One mines blocks and waits for the node to reach the same tip. The other invalidates a block on Core and mines a longer competing branch, then waits for the node to reorg to it. The competing branch is mined to a fresh address so its blocks differ from the invalidated ones.Depends on #85