draft: use SRD coin-selection - #70
Closed
yancyribbens wants to merge 2 commits into
Closed
Conversation
yancyribbens
force-pushed
the
0619-use-srd-coin-selection
branch
from
June 19, 2026 16:29
6c8fc22 to
e77ff62
Compare
yancyribbens
force-pushed
the
0619-use-srd-coin-selection
branch
from
June 19, 2026 16:38
e77ff62 to
8f149f3
Compare
yancyribbens
force-pushed
the
0619-use-srd-coin-selection
branch
from
June 22, 2026 12:56
8f149f3 to
fe3f7a0
Compare
CHANGE_LOWER is a bitcoin-core invariant that says do not make a change output for anything bellow this amount.
yancyribbens
force-pushed
the
0619-use-srd-coin-selection
branch
from
June 22, 2026 12:58
fe3f7a0 to
ffc625b
Compare
Contributor
Author
|
rebased |
Contributor
Author
|
let use #74 instead |
Contributor
Author
|
Started working on some updates to coin-selection to make it more ergonomic. Hopefully you guys don't mind, but I borrowed your naming convention of impl Spendable for Coin<'_> {
fn total_weight(&self) -> Weight {}
fn value(&self) -> Amount {}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to draft this instead of #68
Uses
SRDwhich doesn't require knowledge oflong_term_fee_rateorcost_of_changeand is suitable for testing. Can follow up with another PR to addBnBandCoinGrinderonce we have more parameters.If this looks ok, will do some cleanup and remove from draft state.