node: confirm broadcast delivery before closing the connection - #66
Merged
rustaceanrob merged 1 commit intoJun 18, 2026
Merged
Conversation
broadcast_transaction opened a connection, sent the transaction, but closed the connection right away. Closing immediately tore the connection down before the peer had relayed the transaction. The transaction was dropped, so a valid broadcast reported success but never showed up in the mempool. Send a ping after the transaction and wait for the matching pong before closing. A peer handles a connection's messages in order, so the pong cannot arrive until the transaction ahead of it was processed, which confirms the peer took it in.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
broadcast_transaction opened a connection, sent the transaction, but closed the connection right away. Closing immediately tore the connection down before the peer had relayed the transaction. The transaction was dropped, so a valid broadcast reported success but never showed up in the mempool.
Send a ping after the transaction and wait for the matching pong before closing. A peer handles a connection's messages in order, so the pong cannot arrive until the transaction ahead of it was processed, which confirms the peer took it in.
Part of #51.