Bump MSRV to 1.85.0 - #49
Merged
Merged
Conversation
Ubuntu `26.04` supports Rust `1.91` and above. `bdk_wallet` has an MSRV of `1.85.0`. Given that we will likely want to add a wallet here, an MSRV bump seems appropriate.
Contributor
I always felt like it was an issue that bitcoin-core node packages it's wallet in the same repo and code-base as the node. Agree though that it is useful to add some interface for wallet code. |
Contributor
|
Although, I think adding a wallet maybe as a workspace member so that it compiles together would be smart. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ubuntu
26.04supports Rust1.91and above.bdk_wallethas an MSRV of1.85.0. Given that we will likely want to add a wallet here, an MSRV bump seems appropriate.