Add support for writing data-less sectors in IMD. #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Yes this is a tough one and I'm sure mixing types in the list will break some list users. Mypy ought to be able to detect that but I probably nobbled it with the not-very-nice assignment to |
keirf
force-pushed
the
master
branch
2 times, most recently
from
c6e4897 to
5cc6fb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds sector record 0 type support to the IMD writer.
It currently adds IDAM areas into the sector list. Most writers
seem to be able to skip these appropriately, however I'm not
sure mixing data types in the sector list is the best approach.
Other approaches included a None or special DAM, or a dedicated
list of IDAMs like the IAM list.
The reader can read these back but currently does not encode a
flux stream without a DAM.
(it does seem this feature is relatively poorly supported in
IMD readers as well)