Merge pull request #262 from gopavasanth/T398335

BirushaNdegeya · web-flow · commit e04a44db3ccf · 2025-12-16T14:50:38.000+02:00
fix: include continent in formData when parsing URL parameters
diff --git a/src/api/fetchPageViewsCount.js b/src/api/fetchPageViewsCount.js
@@ -12,12 +12,14 @@ const fetchPageViewsCount = async (specification) => {
         end = `${todayYear}${todayMonth}${todayDay}`,
     } = specification;
     try {
-        const response = await axios.get(
-            `https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/${project}/${acess}/${agents}/${article}/${dateType}/${start}/${end}`,
-        );
+        const encodedArticle = encodeURIComponent((article || '').replace(/\s+/g, '_'));
+        const url = `https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/${project}/${acess}/${agents}/${encodedArticle}/${dateType}/${start}/${end}`;
+        const response = await axios.get(url);
         return response.data;
     } catch (error) {
-        return;
+        // On error (404 or network), return an empty items array so callers can
+        // treat it as "no data" instead of triggering a fetch error UI.
+        return { items: [] };
     }
 };
 
diff --git a/src/components/PageViews/ArticleViewsGraph.jsx b/src/components/PageViews/ArticleViewsGraph.jsx
@@ -28,32 +28,34 @@ export default function ArticleViewsGraph() {
         try {
             const results = await Promise.all(
                 pages.map(async (page) => {
-                    const response = await fetchPageViewsCount({
-                        article: page,
-                        project,
-                        acess: platform,
-                        agents: agent,
-                        dateType: dateType?.toLowerCase(),
-                        start: dates.start,
-                        end: dates.end,
-                    });
+                    try {
+                        const response = await fetchPageViewsCount({
+                            article: page,
+                            project,
+                            acess: platform,
+                            agents: agent,
+                            dateType: dateType?.toLowerCase(),
+                            start: dates.start,
+                            end: dates.end,
+                        });
 
-                    if (!response?.items) {
-                        throw new Error('Invalid response format');
-                    }
+                        const views = Array.isArray(response?.items) ? response.items : [];
 
-                    const views = response.items;
-                    const dates = views.map((view) => {
-                        const year = view.timestamp.substring(0, 4);
-                        const month = view.timestamp.substring(4, 6);
-                        const day = view.timestamp.substring(6, 8);
-                        return `${year}-${month}-${day}`;
-                    });
-                    const counts = views.map((view) => view.views);
-                    return { article: page, dates, counts };
+                        const viewDates = views.map((view) => {
+                            const year = view.timestamp.substring(0, 4);
+                            const month = view.timestamp.substring(4, 6);
+                            const day = view.timestamp.substring(6, 8);
+                            return `${year}-${month}-${day}`;
+                        });
+                        const counts = views.map((view) => view.views);
+                        return { article: page, dates: viewDates, counts };
+                    } catch (e) {
+                        return { article: page, dates: [], counts: [] };
+                    }
                 }),
             );
 
+
             const combinedDates = [...new Set(results.flatMap((data) => data.dates))].sort();
             const datasets = results.map((data, index) => ({
                 label: decodeURIComponent(data.article),
diff --git a/src/pages/Home.jsx b/src/pages/Home.jsx
@@ -107,6 +107,7 @@ function App() {
             const formData = {};
             formData.country = params[0];
             formData.access = params[1];
+            formData.continent = params[3];
             formData.year = date[0];
             formData.month = date[1];
             formData.day = date[2];
