Better kernels for row sum and tr(AB^T): ver. 2 #3973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d added more NVTX markers
…n-multithreaded-numerator
… chain-training.cc
…ldi into persistent_add_row_sum_mat
…nel when the two matrices are the same
Contributor
|
Thanks!! Merging. |
pc-seawind
pushed a commit
to pc-seawind/kaldi
that referenced
this pull request
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated PR based on #3954 with the only addition being a fixed LSTM test in
cudamatrix/cu-math-testthat is not sensitive to round-off errors inTraceMatMat. The test fix is the 2nd option mentioned in #3954 (comment).