Implement namespace scoping for /api/agents by maazghani · Pull Request #1878 · kagent-dev/kagent

maazghani · 2026-05-15T19:41:46Z

Addresses #1812 and @EItanya's feedback to implement server side. If this PR lands, I have a draft of a potential UI implementation.

Adds GET /api/agents/{namespace} to work like kubectl get agent -n kagent, and leaving GET /api/agents as kubectl get agent -A.

Re-use existing namespace validation pattern to return invalid namespaces as 400 bad request.

implemented HandleListAgentsForNamespace handler with tests
DRY'd out Agent + AgentHarness aggregation logic into a shared helper
registered route for /{namespace} in server.go
updated ListAgents to hit path-based /api/agents/${namespace}

Ran e2e tests using kind-backed env successfully, and validated namespace-filtering works.

Signed-off-by: Maaz Ghani <mghani@lululemon.com>

maazghani · 2026-05-15T23:57:49Z

Verification performed so far:

$ kubectl get agent -n kagent
NAME                             TYPE          RUNTIME   READY   ACCEPTED
argo-rollouts-conversion-agent   Declarative   python    True    True
cilium-debug-agent               Declarative   python    True    True
cilium-manager-agent             Declarative   python    True    True
cilium-policy-agent              Declarative   python    True    True
helm-agent                       Declarative   python    True    True
istio-agent                      Declarative   python    True    True
k8s-agent                        Declarative   python    True    True
kebab-agent                      BYO                     True    True
kgateway-agent                   Declarative   python    True    True
observability-agent              Declarative   python    True    True
promql-agent                     Declarative   python    True    True
test-agent-dqm5m                 Declarative   go        True    True
test-agent-p8mfv                 Declarative   python    True    True

$ curl -s $KAGENT_URL/api/agents/kagent | jq '[.data[].agent.metadata.name]'
[
  "kebab-agent",
  "test-agent-p8mfv",
  "cilium-manager-agent",
  "istio-agent",
  "k8s-agent",
  "observability-agent",
  "promql-agent",
  "cilium-policy-agent",
  "kgateway-agent",
  "test-agent-dqm5m",
  "argo-rollouts-conversion-agent",
  "helm-agent",
  "cilium-debug-agent"
]

$ curl -s $KAGENT_URL/api/agents/default | jq .
{
  "error": false,
  "message": "Successfully listed agents"
}

$ curl -s $KAGENT_URL/api/agents/invalid!
{"error":"invalid namespace \"invalid!\": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?'): invalid namespace \"invalid!\": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')"}

maazghani · 2026-05-15T23:59:23Z

@claude please review as well. Edit: or not

Copilot

Pull request overview

This PR adds namespace-scoped agent listing support by introducing a new /api/agents/{namespace} endpoint, wiring it into both the UI’s getAgents action and the Go API client, and adding handler tests to validate the filtering behavior.

Changes:

Add GET /api/agents/{namespace} route and handler to list Agents/AgentHarnesses restricted to a namespace (with namespace validation).
Update UI getAgents action to optionally call the namespace-scoped endpoint.
Extend Go API client to support listing agents for a specific namespace and add handler test coverage.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
ui/src/app/actions/agents.ts	Add optional namespace parameter to `getAgents()` to call a namespace-scoped agents endpoint.
go/core/internal/httpserver/server.go	Register a new `GET /api/agents/{namespace}` route.
go/core/internal/httpserver/handlers/agents.go	Implement `HandleListAgentsForNamespace` with Kubernetes namespace validation and namespace-scoped listing.
go/core/internal/httpserver/handlers/agents_test.go	Add tests ensuring namespace-scoped listing filters both Agents and AgentHarnesses.
go/api/client/agent.go	Add a client method (and interface entry) for listing agents by namespace.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

maazghani · 2026-05-16T00:29:49Z

Please ignore my force-pushes I forgot to sign the commit(s).

Signed-off-by: Codex <codex@openai.com> Signed-off-by: Maaz Ghani <maazghani@gmail.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Signed-off-by: Maaz Ghani <maazghani@gmail.com>

EItanya

Hey there, I'm a little worried about using a path var here is a bit fragile, can we potentially use a query variable instead?

maazghani · 2026-05-18T15:33:26Z

@EItanya

Thanks, makes sense.

I used the path because was thinking of namespace as scope (like future RBAC support), not just a filter, and it matched the existing /api/agents/{namespace}/{agent} shape for namespace-aware access later.

Happy to switch this to a query param if that’s preferred.

Implement namespace filtering for /api/agents

95c5b81

Signed-off-by: Maaz Ghani <mghani@lululemon.com>

maazghani force-pushed the maazghani/implement-namespace-kagent-filtering branch from 32a94d8 to 95c5b81 Compare May 15, 2026 19:46

maazghani marked this pull request as ready for review May 15, 2026 23:58

maazghani requested a review from supreme-gg-gg as a code owner May 15, 2026 23:58

Copilot AI review requested due to automatic review settings May 15, 2026 23:58

maazghani requested review from iplay88keys, jmhbh and peterj as code owners May 15, 2026 23:58

maazghani marked this pull request as draft May 15, 2026 23:58

Copilot started reviewing on behalf of maazghani May 15, 2026 23:58 View session

Copilot AI reviewed May 16, 2026

View reviewed changes

Comment thread go/core/internal/httpserver/handlers/agents.go

Comment thread go/api/client/agent.go

Comment thread go/core/internal/httpserver/server.go

maazghani force-pushed the maazghani/implement-namespace-kagent-filtering branch from 7035655 to b6ed0c8 Compare May 16, 2026 00:28

maazghani mentioned this pull request May 16, 2026

implement filtering AgentList by namespace #1813

Closed

maazghani marked this pull request as ready for review May 16, 2026 00:48

maazghani changed the title ~~Draft: Implement namespace filtering for /api/agents~~ Implement namespace filtering for /api/agents May 16, 2026

maazghani marked this pull request as draft May 16, 2026 01:56

fix: filter agents by namespace via list options

0c54895

Signed-off-by: Codex <codex@openai.com> Signed-off-by: Maaz Ghani <maazghani@gmail.com>

maazghani force-pushed the maazghani/implement-namespace-kagent-filtering branch from 54ada34 to 0c54895 Compare May 16, 2026 20:44

maazghani changed the title ~~Implement namespace filtering for /api/agents~~ Implement namespace scoping for /api/agents May 16, 2026

maazghani requested a review from Copilot May 16, 2026 21:20

Copilot started reviewing on behalf of maazghani May 16, 2026 21:21 View session

Copilot AI reviewed May 16, 2026

View reviewed changes

Comment thread go/core/internal/httpserver/handlers/agents.go Outdated

Comment thread go/api/client/agent.go

fix ns validation and ListAgents options error handlign

7163d89

Signed-off-by: Maaz Ghani <maazghani@gmail.com>

maazghani marked this pull request as ready for review May 16, 2026 22:30

peterj approved these changes May 16, 2026

View reviewed changes

EItanya requested changes May 18, 2026

View reviewed changes

Merge branch 'main' into maazghani/implement-namespace-kagent-filtering

1533f40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement namespace scoping for /api/agents#1878

Implement namespace scoping for /api/agents#1878
maazghani wants to merge 4 commits into
kagent-dev:mainfrom
maazghani:maazghani/implement-namespace-kagent-filtering

maazghani commented May 15, 2026 •

edited

Loading

Uh oh!

maazghani commented May 15, 2026 •

edited

Loading

Uh oh!

maazghani commented May 15, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maazghani commented May 16, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

EItanya left a comment

Uh oh!

maazghani commented May 18, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

maazghani commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maazghani commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maazghani commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maazghani commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

EItanya left a comment

Choose a reason for hiding this comment

Uh oh!

maazghani commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

maazghani commented May 15, 2026 •

edited

Loading

maazghani commented May 15, 2026 •

edited

Loading

maazghani commented May 15, 2026 •

edited

Loading

maazghani commented May 16, 2026 •

edited

Loading

maazghani commented May 18, 2026 •

edited

Loading