test(cypress): add billing descriptor coverage for finix#12314
Open
HS-QUALIBOT wants to merge 2 commits into
Open
test(cypress): add billing descriptor coverage for finix#12314HS-QUALIBOT wants to merge 2 commits into
HS-QUALIBOT wants to merge 2 commits into
Conversation
- New spec: cypress-tests/cypress/e2e/spec/Payment/43-BillingDescriptor.cy.js - Config keys: billing_descriptor - Connectors regressed: Finix - Parent issue: QAA-47 Co-Authored-By: Paperclip <noreply@paperclip.ing>
|
Review changes with Changed Files
|
github-actions
Bot
removed
the
S-test-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds Cypress test coverage for the billing descriptor feature on the Finix connector. Three test contexts are covered: the happy path with a standard billing descriptor, an edge case where extra billing descriptor fields are silently dropped, and an invalid billing descriptor phone validation scenario. The Finix connector configuration is extended with the necessary request/response definitions for each scenario.
Additional Changes
cypress-tests/cypress/e2e/spec/Payment/43-BillingDescriptor.cy.js— new spec covering Billing Descriptor happy path + extra-fields edge case + invalid-phone negative casecypress-tests/cypress/e2e/configs/Payment/Finix.js— addedPaymentIntentWithBillingDescriptor,PaymentConfirmWithBillingDescriptor,PaymentIntentWithBillingDescriptorExtraFields,PaymentConfirmWithBillingDescriptorExtraFieldsconfig entriescypress-tests/cypress/e2e/configs/Payment/Utils.js— registered Finix inCONNECTOR_LISTS.INCLUDE.BILLING_DESCRIPTORMotivation and Context
The Finix connector lacked automated regression coverage for billing descriptors. This PR fills that gap so future connector or platform changes affecting billing descriptor passthrough do not silently regress Finix behavior. The tests were generated via the internal QA pipeline (QAA-47) after validation confirmed the feature is in scope for Finix.
Parent pipeline issue: QAA-47
How did you test it?
Full regression suite was executed against the changed connector(s). All
RUNNER_RESULTblocks from the QA pipeline are included verbatim below.Changed-spec verification —
finixSummary
Checklist
cargo +nightly fmt --allcargo clippyLinked issues
Closes #12313
Related to QAA-47