Skip to content

Conversation

@ddalcino
Copy link
Contributor

@ddalcino ddalcino commented May 7, 2023

Fix #181. This will allow both mobile and WASM builds to succeed, when using Qt 6.2+. These new versions of Qt require a parallel installation of the desktop version of Qt, installed alongside the mobile or WASM versions.

As a side effect, this PR also fixes a logic bug in the way the arch input is set by default. When the user does not select an arch on Windows, and the target is set to android, the action selects a Windows desktop arch instead of an android arch. The change that fixes this issue is in its own commit: 8cd6038

This PR makes breaking changes, discussed in the new README_upgrade_guide.md file. For that reason, this change should not be merged into v3 of this action.

This PR uses #179 as a starting point. I needed to use an example project meant for mobile devices in order to test Qt for Android properly, and there are some good ones in the Examples directory that you can install using aqt install-example. It was easier to accomplish that using the changes in #179 than in some other way.

I have added tests for android in their own workflow. This will result in some code duplication, but IMHO it's a lot easier to read and to reason about the tests this way than it would have been if I had added the tests to the existing test.yml workflow.

@ddalcino ddalcino marked this pull request as ready for review May 9, 2023 03:30
@jurplel jurplel merged commit 5e6aabb into jurplel:master May 13, 2023
@ddalcino ddalcino deleted the use-auto-desktop branch September 9, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When installing qt wasm_32, install corresponding qmake with them.

2 participants