Skip to content

Fix docs for the new pydata sphinx theme #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jtpio merged 4 commits into from
Sep 26, 2023
Merged

Fix docs for the new pydata sphinx theme #1165

jtpio merged 4 commits into from
Sep 26, 2023

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented Sep 26, 2023 •
edited
Loading

References

Similar to jupyterlab/jupyterlab#15141 and jupyter/notebook#7074

Code changes

Docs config update.

User-facing changes

Documentation changes:

  • Fix navbar
  • Remove the big wordmark from the index page (the wordmark is already in the nav bar)
  • Move try buttons to the top of the index page

Before

image

After

image

Backwards-incompatible changes

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023

lite-badge 👈 Try it on ReadTheDocs

@jtpio jtpio added the documentation Improvements or additions to documentation label Sep 26, 2023
@jtpio jtpio added this to the 0.2.0 milestone Sep 26, 2023
jtpio
jtpio commented Sep 26, 2023
View reviewed changes
docs/conf.py
"logo": {
"alt_text": "JupyterLite",
"image_light": "_static/wordmark.svg",
"image_dark": "_static/wordmark-dark.svg",
Copy link
Member Author

@jtpio jtpio Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is not picked up when using the dark theme:

image

Copy link
Member Author

@jtpio jtpio Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will open an issue as a follow-up.

Copy link
Member Author

@jtpio jtpio Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #1166

@jtpio jtpio marked this pull request as ready for review September 26, 2023 17:48
@jtpio jtpio merged commit 710b66f into jupyterlite:main Sep 26, 2023
@jtpio jtpio deleted the fix-docs branch September 26, 2023 17:53
This was referenced Sep 26, 2023
Closed
Merged
@jtpio
Copy link
Member Author

jtpio commented Sep 27, 2023

@meeseeksdev please backport to 0.1.x

@meeseeksmachine meeseeksmachine mentioned this pull request Sep 27, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlite that referenced this pull request Sep 27, 2023
@jtpio @meeseeksmachine
Backport PR jupyterlite#1165: Fix docs for the new pydata sphinx theme
3b57268
jtpio added a commit that referenced this pull request Sep 27, 2023
@meeseeksmachine @jtpio
Backport PR #1165 on branch 0.1.x (Fix docs for the new pydata sphinx…
cd79c07 
… theme) (#1168)

* Backport PR #1165: Fix docs for the new pydata sphinx theme

* Edit link to retro

---------

Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

0.2.0

Development

Successfully merging this pull request may close these issues.

1 participant

@jtpio