Skip to content

Conversation

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Feb 6, 2021

References

Code changes

Our previous locking solution is now in maintenance mode (https://github.com/dessant/lock-threads-app). The successor is a workflow. This converts our locking configuration to use the workflow version.

I also increased the inactive timer to 180 days. Sometimes I’ve noticed we want to refer to a recent PR, but the backlink is not put in because the PR is locked. This lets us easily refer to a PR up to 6 months old and have the auto-backlinking work well.

User-facing changes

Backwards-incompatible changes

@jasongrout jasongrout added this to the 3.1 milestone Feb 6, 2021
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Our previous locking solution is now in maintenance mode (https://github.com/dessant/lock-threads-app). The successor is a workflow. This converts our locking configuration to use the workflow version.

I also increased the inactive timer to 180 days. Sometimes I’ve noticed we want to refer to a recent PR, but the backlink is not put in because the PR is locked. This lets us easily refer to a PR up to 6 months old and have the auto-backlinking work well.
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 48bdf6d into jupyterlab:master Feb 6, 2021
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

maintenance status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants