Skip to content

Ensure codemirror cursor size #3164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ian-r-rose merged 1 commit into from
Oct 30, 2017
Merged

Ensure codemirror cursor size #3164

ian-r-rose merged 1 commit into from
Oct 30, 2017

Conversation

@blink1073
Copy link
Contributor

@blink1073 blink1073 commented Oct 30, 2017

Follows jupyter/notebook#2983. Fixes #3097.

@blink1073 blink1073 added this to the Beta milestone Oct 30, 2017
ian-r-rose
ian-r-rose approved these changes Oct 30, 2017
View reviewed changes
Copy link
Member

@ian-r-rose ian-r-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ian-r-rose ian-r-rose merged commit dda1102 into jupyterlab:master Oct 30, 2017
@blink1073
Copy link
Contributor Author

blink1073 commented Oct 30, 2017

@meeseeksdev backport to 0.28.x

lumberbot-app bot pushed a commit that referenced this pull request Oct 30, 2017
@ian-r-rose
Backport PR #3164: Ensure codemirror cursor size
6ff954d
@lumberbot-app lumberbot-app bot mentioned this pull request Oct 30, 2017
Merged
@blink1073
Copy link
Contributor Author

blink1073 commented Oct 30, 2017

@meeseeksdev say I'm back baby!

@lumberbot-app
Copy link

lumberbot-app bot commented Oct 30, 2017

I'm back baby!

blink1073 added a commit that referenced this pull request Oct 31, 2017
@blink1073
Merge pull request #3166 from jupyterlab/auto-backport-of-pr-3164
76809a6 
Backport PR #3164 on branch 0.28.x
@blink1073 blink1073 deleted the codemirror-cursor branch November 23, 2017 12:06
@willurd willurd mentioned this pull request Nov 24, 2018
Open
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ian-r-rose ian-r-rose ian-r-rose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug pkg:codemirror status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Browser Compatibility

Projects

None yet

Milestone

0.31.0

Development

Successfully merging this pull request may close these issues.

Cursors are not showing in CodeMirror

2 participants

@blink1073 @ian-r-rose