Skip to content

Conversation

@Meriem-BenIsmail
Copy link
Member

@Meriem-BenIsmail Meriem-BenIsmail commented Sep 19, 2025

References

Follow up work to PR #17719, thanks @martinRenou 🚀 !

Code changes

  • Added a global minimap setting in the settings registry (persistent across sessions and all notebooks).
  • Added a per-notebook toggle in the View menu , using semantic commands
  • Updated WindowedList to enable the minimap in all windowing modes like in the full mode.

User-facing changes

  • Users can now control the minimap in two ways:
    • Globally through the Settings menu (applies to all notebooks).
    • Per notebook via the View → Show Minimap toggle (applies only to the active notebook).
  • The minimap toolbar button is now removed.
  • The minimap is available in full/defer/none/contentVisibility modes. It is disabled by default.
Screencast.from.2025-09-19.14-59-58.webm

Backwards-incompatible changes

None.

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@Meriem-BenIsmail Meriem-BenIsmail changed the title enable minimap for all modes Enable the minimap for all modes Sep 19, 2025
@krassowski krassowski added this to the 4.5.0 milestone Sep 19, 2025
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Users can now control the minimap in two ways:
    • Globally through the Settings menu (applies to all notebooks).
    • Per notebook via the View → Show Minimap toggle (applies only to the active notebook).

I like that it adds an entry point for enabling minimap for text editors too!

Could we move the menu to View → Appearance? This is where it is in VS Code:

image

.

  • The minimap toolbar button is now removed.

I guess that's fine? I think there will be some users asking if we can bring it back, I wonder if it should be an option even if we agree that it is not needed to be there by default.

CC @afshin who added it there.

  • The minimap is available in full/defer/none/contentVisibility modes. It is disabled by default.

🎉

@jtpio
Copy link
Member

jtpio commented Sep 24, 2025

Just merged main into this branch to grab some CI fixes (to have a better idea of what the remaining failures are).

@Meriem-BenIsmail
Copy link
Member Author

Meriem-BenIsmail commented Sep 24, 2025

Thanks ! The remaining failures are due to the snapshots mismatches caused by the removal of the minimap button in the toolbar. If we decide to go in the same path then I'll trigger the updates.

@Meriem-BenIsmail
Copy link
Member Author

Meriem-BenIsmail commented Sep 24, 2025

Current place of the Show Minimap option

image

@jtpio
Copy link
Member

jtpio commented Sep 24, 2025

the removal of the minimap button in the toolbar.

This sounds like a good idea 👍

The notebook toolbar is already a bit crowded with many other buttons, so it looks fine to remove it. And enabling the minimap feels a bit more like a global setting than a per-notebook setting, so having it in the settings and also as a menu item makes sense.

@krassowski
Copy link
Member

bot please update snapshots

@github-actions
Copy link
Contributor

Documentation snapshots updated.

@github-actions
Copy link
Contributor

Galata snapshots updated.

@krassowski
Copy link
Member

krassowski commented Sep 25, 2025

Edit: Done in c636cd0.

The remaining two failing tests:

    [jupyterlab] › test/jupyterlab/notebook-toolbar.test.ts:205:7 › Reactive toolbar › Reducing toolbar width should display opener item 
    [jupyterlab] › test/jupyterlab/notebook-toolbar.test.ts:223:7 › Reactive toolbar › Items in popup toolbar should have the same order 

require manual updates:

Error: expect(locator).toHaveCount(expected) failed

Locator:  locator('.jp-NotebookPanel-toolbar').locator('.jp-Toolbar-item:visible')
Expected: 15
Received: 14
Timeout:  5000ms

Call log:
  - Expect "toHaveCount" with timeout 5000ms
  - waiting for locator('.jp-NotebookPanel-toolbar').locator('.jp-Toolbar-item:visible')
    9 × locator resolved to 14 elements
      - unexpected value "14"


  207 |   }) => {
  208 |     const toolbar = page.locator('.jp-NotebookPanel-toolbar');
> 209 |     await expect(toolbar.locator('.jp-Toolbar-item:visible')).toHaveCount(15);
      |                                                               ^

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Meriem-BenIsmail!

@krassowski krassowski merged commit 80ff200 into jupyterlab:main Sep 25, 2025
82 checks passed
@krassowski krassowski changed the title Enable the minimap for all modes Enable the minimap for all windowing modes Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants