Skip to content

Use console for debugger evaluation #17892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
krassowski merged 48 commits into from
Sep 26, 2025
Merged

Use console for debugger evaluation #17892

krassowski merged 48 commits into from
Sep 26, 2025

Conversation

@gjmooney
Copy link
Contributor

@gjmooney gjmooney commented Sep 15, 2025 •
edited
Loading

This replaces the current debugger evaluate dialog with a console.

debugconsole.mp4

References

Closes #17849

Code changes

User-facing changes

Enables a console interface for interacting with the debugger.

Backwards-incompatible changes

@jupyterlab-probot
Copy link

jupyterlab-probot bot commented Sep 15, 2025

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@github-actions github-actions bot added pkg:apputils tag:CSS For general CSS related issues and pecadilloes pkg:debugger Design System CSS labels Sep 15, 2025
krassowski
krassowski reviewed Sep 18, 2025
View reviewed changes
@krassowski
Copy link
Member

krassowski commented Sep 22, 2025

^ picked merge conflicts from a new alpha release

martinRenou
martinRenou reviewed Sep 24, 2025
View reviewed changes
martinRenou
martinRenou approved these changes Sep 26, 2025
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me! Thanks a lot for this :D

@krassowski
Copy link
Member

krassowski commented Sep 26, 2025

Long term this code would not live here, it would be the kernel responsibility to implement completion for the debugger. Another control channel message next to "evaluate"?

Can you open an issue/pre-JEP (whatever is needed) so that we do not lose track of this discussion?

@martinRenou
Copy link
Member

martinRenou commented Sep 26, 2025

Will do!

@martinRenou martinRenou mentioned this pull request Sep 26, 2025
Open
@martinRenou
Copy link
Member

martinRenou commented Sep 26, 2025

jupyter/enhancement-proposals#135

krassowski
krassowski reviewed Sep 26, 2025
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nearly there, some minor suggestions on command names and translation wrappers

packages/debugger/src/debugger.ts Outdated
Comment on lines 130 to 134
export const invokeConsole = 'debugger:invoke-console';

export const selectConsole = 'debugger:select-console';

export const executeConsole = 'debugger:execute-console';
Copy link
Member

@krassowski krassowski Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest making the names of the commands easier to understand as this is user-facing:

Suggested change
export const invokeConsole = 'debugger:invoke-console';
export const selectConsole = 'debugger:select-console';
export const executeConsole = 'debugger:execute-console';
export const invokeConsole = 'debugger:invoke-console-completer';
export const selectConsole = 'debugger:select-console-completion';
export const executeConsole = 'debugger:run-in-console';

I see that normal console has console:run-forced and console:run-unforced do we need this distinction here too?

Copy link
Contributor Author

@gjmooney gjmooney Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This console won't execute unforced since that results in a kernel request.

krassowski
krassowski reviewed Sep 26, 2025
View reviewed changes
krassowski
krassowski approved these changes Sep 26, 2025
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - thank you @gjmooney!

Before we merge it, we should first merge #17928 to ensure tests pass (waiting on anyone to review).

@krassowski krassowski merged commit 31d1a90 into jupyterlab:main Sep 26, 2025
83 checks passed
@krassowski krassowski mentioned this pull request Sep 26, 2025
Closed
This was referenced Sep 29, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krassowski krassowski krassowski approved these changes

+1 more reviewer

@martinRenou martinRenou martinRenou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gjmooney gjmooney

Labels

Design System CSS enhancement pkg:debugger tag:CSS For general CSS related issues and pecadilloes tag:Testing

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

Debugger: Replace the evaluate dialog with a real console

3 participants

@gjmooney @krassowski @martinRenou