Make ILabShell optional in the logconsole extension
#17430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
github-actions
bot
added
tag:CSS
3 tasks
jtpio
commented
Mar 27, 2025
| return labShell.currentPath; | ||
| } | ||
| // For other shells, set the source to the current widget path | ||
| if (currentWidget && currentWidget instanceof DocumentWidget) { |
Member
Author
There was a problem hiding this comment.
For reference, this follows the same approach used by ILabShell:
jupyterlab/packages/application/src/shell.ts
Lines 1424 to 1426 in 85c82eb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Noticed when trying to add support for the
downarea in Notebook 7.Current the logconsole plugin has a hard requirement on
ILabShell, which makes reusing the plugin downstream difficult.Code changes
Handle the case where
ILabShellis missing.User-facing changes
None for JupyterLab users.
Chances to get the log console to work for Notebook users.
Using this patch downstream in Notebook:
Backwards-incompatible changes
None