Skip to content

Fix the handling of the file browser configuration #16870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jtpio merged 18 commits into from
Oct 21, 2024
Merged

Fix the handling of the file browser configuration #16870

jtpio merged 18 commits into from
Oct 21, 2024

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented Oct 15, 2024 •
edited
Loading

References

Fixes #14623

Code changes

Move the handling of the file browser settings to a separate plugin, so it's easier to change the settings and not have them collide in downstream applications such as Notebook 7.

User-facing changes

None for JupyterLab users.

For Notebook users, using jupyter/notebook#7481, the file browser will show different defaults than JupyterLab (checkboxes, file size column, single click navigation), without having to modify the settings and have these defaults be reflected in JupyterLab too:

filebrowser-settings-notebook-lab.webm

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

jupyterlab-probot bot commented Oct 15, 2024

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@jtpio jtpio added the bug label Oct 15, 2024
@jtpio
Copy link
Member Author

jtpio commented Oct 15, 2024

Adding to 4.3.0 as this is actually a bug fix (and hoping to finish the PR before the final release).

@jtpio jtpio added this to the 4.3.0 milestone Oct 15, 2024
@jtpio jtpio mentioned this pull request Oct 16, 2024
Merged
2 tasks
@jtpio jtpio changed the title Fix setting of the file browser defaults Fix the handling of the file browser configuration Oct 16, 2024
@jtpio
Copy link
Member Author

jtpio commented Oct 16, 2024

hmm the UI test failures seem to be consistent but are not expected, need to check what is happening there:

example-diff

@jtpio
Copy link
Member Author

jtpio commented Oct 17, 2024

On a local install from main, loading JupyterLab would set the following size for the file browser columns:

image

Switching to this branch:

image

So moving the logic to a separate plugin seems to introduce a small delay that has some effect on the final columns widths, which also seems to be reflected in the UI tests.

Maybe it's then still fine to update the reference snapshots, as the differences are quite minor in the end.

@jtpio
Copy link
Member Author

jtpio commented Oct 17, 2024

bot please update snapshots

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024

Documentation snapshots updated.

@jtpio jtpio force-pushed the fix-browser-settings branch from a263665 to fe794f1 Compare October 17, 2024 09:17
@jtpio
Copy link
Member Author

jtpio commented Oct 17, 2024

bot please update snapshots

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024

Documentation snapshots updated.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024

Galata snapshots updated.

@jtpio jtpio mentioned this pull request Oct 17, 2024
Open
@jtpio
Copy link
Member Author

jtpio commented Oct 17, 2024 •
edited
Loading

Looks like CI is now passing ✔️ (except for check-links, tracked in #16837 (comment))

If we are fine with the minor updates to the snapshots, this should be ready to go.

@jtpio jtpio marked this pull request as ready for review October 17, 2024 16:35
krassowski
krassowski reviewed Oct 21, 2024
View reviewed changes
@jtpio @krassowski
Update packages/filebrowser-extension/src/index.ts
211cc6a 
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
krassowski
krassowski approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jtpio!

@jtpio jtpio merged commit d6f97bd into jupyterlab:main Oct 21, 2024
@jtpio jtpio deleted the fix-browser-settings branch October 21, 2024 11:36
ImpSy pushed a commit to spotinst/jupyterlab that referenced this pull request Jan 7, 2025
@jtpio @github-actions
@krassowski @ImpSy
Fix the handling of the file browser configuration (jupyterlab#16870)
e55cafa 
* Fix setting of the file browser defaults

* Move handling of the file browser settings to a separate plugin

* add docstring

* rename plugin

* add description

* handle no settingRegistry

* fix settings

* keep same logic as before

* keep previous assignment

* Update Playwright Snapshots

* Update Playwright Snapshots

* revert partial snapshot update

* update example snapshots

* more snapshot update

* simplify

* Update packages/filebrowser-extension/src/index.ts

Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@krassowski krassowski krassowski approved these changes

Assignees

@jtpio jtpio

Labels

bug pkg:filebrowser tag:Examples tag:Testing

Projects

None yet

Milestone

4.3.0

Development

Successfully merging this pull request may close these issues.

Better handling of the file browser configuration

2 participants

@jtpio @krassowski