Implement resizing for the file browser #16646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
github-actions
bot
added
pkg:filebrowser
tag:CSS
This change: - reduces visual diff - allows more space for the name/modified/size columns when checkboxes are shown as there is less space taken up by the resize handle for a column which always presents a very narrow checkbox and thus does not really benefit from resizing
but all columns have sizes even they are not resizable.
krassowski
force-pushed
the
resize-file-browser
branch
from
d65bb9f to
829bc59
Compare
Member
Author
|
Because I had to rework (=improve) the caret positioning, the caret is no longer inflating the height of the column headers. This does not change the height as seen when checkboxes are enabled (because the checkbox in the header is inflating the height too) but it reduces the height otherwise:
I personally don't mind having a little bit more space for files, but if there are strong opinions I am happy to reinstate the extra pixel or two - just let me know. |
krassowski
force-pushed
the
resize-file-browser
branch
from
2ea1d74 to
7748235
Compare
afshin
reviewed
Aug 10, 2024
| } else if (showFileCheckboxes && !checkboxWrapper) { | ||
| const checkboxWrapper = this.createCheckboxWrapperNode(); | ||
| node.insertBefore(checkboxWrapper, iconContainer); | ||
| nameColumn.insertAdjacentElement('beforebegin', checkboxWrapper); |
Member
There was a problem hiding this comment.
Switching to insertAdjacentElement is nice.
afshin
reviewed
Aug 10, 2024
afshin
approved these changes
Aug 10, 2024
Member
afshin
left a comment
afshin
left a comment
There was a problem hiding this comment.
Thank you, @krassowski! I made one minor comment.
Co-authored-by: Afshin Taylor Darian <git@darian.link>
krassowski
force-pushed
the
resize-file-browser
branch
from
80f9eee to
8c2db7c
Compare
This was referenced Aug 11, 2024
Closed
ImpSy
pushed a commit
to spotinst/jupyterlab
that referenced
this pull request
Jan 7, 2025
* Implement resizing for file browser * Fine tune pixels, expand docs * Do not add a resize handle for checkboxes column This change: - reduces visual diff - allows more space for the name/modified/size columns when checkboxes are shown as there is less space taken up by the resize handle for a column which always presents a very narrow checkbox and thus does not really benefit from resizing * Fix column sorting * Fix typing on sizing: `is_selected` is no resizable, but all columns have sizes even they are not resizable. * Add missing freeze filter for custom css snapshot test * Update snapshots * Remove prefix underscore from protected attribute Co-authored-by: Afshin Taylor Darian <git@darian.link> --------- Co-authored-by: Afshin Taylor Darian <git@darian.link>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Code changes
FileBrowserandDirListingwidgets now accept optionalstate?: IStateDBoption which allows the listing to restore the size of columns; this follows the pattern already used in theFileBrowserModelDirListing.IRenderergets a new optionalupdateItemSize?(...): voidmethod which is a fast path to refresh the widths in the listing without updating other elementsDirListing.IRenderer.updateItemModified()will now check if there is any work to be done to avoid costlyformat()callsUser-facing changes
Backwards-incompatible changes
None