Fix settings editor missing plugins with transform step or registered late #16523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
protected to enable testing the pre-fetch behaviour
krassowski
changed the title
krassowski
changed the title
krassowski
changed the title
fcollonval
requested changes
Jul 1, 2024
Member
fcollonval
left a comment
fcollonval
left a comment
There was a problem hiding this comment.
Thanks @krassowski
i have a minor suggestion and I spotted a regression. In the settings editor, the plugin list does not update when its status changes from all default values to some custom values:
| .catch(reason => { | ||
| console.error(`Failed to load the plugin list model:\n${reason}`); | ||
| }); | ||
| this._model.changed.connect(() => { |
Member
There was a problem hiding this comment.
Should we connect this signal only after this._model.ready to ensure we don't trigger update when the model is not yet ready?
ImpSy
pushed a commit
to spotinst/jupyterlab
that referenced
this pull request
Jan 7, 2025
… late (jupyterlab#16523) * Fix setings editor not being loaded for some plugins * Add tests for `PluginList.Model`, expose `SettingsRegistry.ready` as protected to enable testing the pre-fetch behaviour * Handle hanging promises * Connect `model.changed` signal after the model is `ready` * Fix plugin list not updating when settings change from default * Lint test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #15871
Code changes
PluginListandSettingsEditorwhich lead to loading the settings for each plugin twice (this leads to a minimal performance improvement because the fetched plugins were already cached before)PluginList.Modelmodel class which is used by bothPluginListandSettingsEditorPluginList.sortPlugins()- this function was only used to implement the aforementioned duplicated logic; an equivalent function is now one of the private model methodstoSkipoption previously passed to thePluginListconstructor which should now be supplied to thePluginList.ModelinsteadPluginList.registryattribute - the plugin list should not provide the settings registry as it is not its responsibility; private_registryname is to be used going forwardUser-facing changes
transform), the settings are now correctly shown in the editorBackwards-incompatible changes
None