Update migration guide about the Toolbar selector #15501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
krassowski
reviewed
Dec 10, 2023
Member
krassowski
left a comment
krassowski
left a comment
There was a problem hiding this comment.
Thank you, leaving one grammar suggestion, a note and a question.
| - The icon in the ``ToolbarButtonComponent`` is a direct child of the ``jp-button`` component. | ||
|
|
||
| The icon was previously encapsulated in a span with the class ``.jp-ToolbarButtonComponent-icon``. | ||
| Accessing that icon to change its properties require now something like ``jp-button > svg``. |
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
krassowski
changed the title
krassowski
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some documentation in the migration guide about the
ToolbarandToolbarButtonComponentselectors.References
#15021 includes web components, which change the DOM of the
ToolbarandToolbarButtonComponent.Code changes
None
User-facing changes
None
Backwards-incompatible changes
None