Skip to content

Conversation

@fcollonval
Copy link
Member

References

Fixes #15212

Code changes

None

Switch from hub to gh CLI in CI jobs

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added this to the 3.6.x milestone Oct 3, 2023
@fcollonval fcollonval linked an issue Oct 3, 2023 that may be closed by this pull request
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@krassowski krassowski merged commit 773a1a7 into main Oct 3, 2023
@krassowski krassowski deleted the 15212-hub-github-cli-tool-has-been-removed-on-october-2nd branch October 3, 2023 17:50
@krassowski
Copy link
Member

@meeseeksdev please backport to 4.0.x

@krassowski
Copy link
Member

@meeseeksdev please backport to 3.6.x

@lumberbot-app
Copy link

lumberbot-app bot commented Oct 3, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 3.6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 773a1a7d2e80210adb8886eb9527dd2256bd2bf6
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #15213: Switch from hub to gh CLI'
  1. Push to a named branch:
git push YOURFORK 3.6.x:auto-backport-of-pr-15213-on-3.6.x
  1. Create a PR against branch 3.6.x, I would have named this PR:

"Backport PR #15213 on branch 3.6.x (Switch from hub to gh CLI)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

fcollonval added a commit that referenced this pull request Oct 4, 2023
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
@fcollonval fcollonval modified the milestones: 3.6.x, 4.0.x Oct 4, 2023
@fcollonval
Copy link
Member Author

In fact we are not using it on 3.6.x. So the backport is not needed, sorry for the confusion

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hub GitHub CLI tool has been removed on October 2nd

3 participants