-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Enable Playwright trace #15087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Playwright trace #15087
Conversation
|
Thanks for making a pull request to jupyterlab! |
|
Since the UI tests are failing on this PR (#14947) it's a good occasion to show what it looks like when opening the Playwright report: playwright-trace-demo.mp4 |
|
30 MB is not that bad, I think it is worth it. I was also considering whether to enable console log forwarding as in: krassowski@8e5cb06, which has a downside of making the progress a bit more noisy but then we probably should take care not to spam with logs anyways so maybe this is a feature not an issue - thoughts? |
👍
We could add a configurable fixture for that to get the console to be forwarded only on retry on the CI for example. But that could be changed locally for debug. |
fcollonval
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jtpio
Right for this run it's fine. But I think it will be proportional to the number of failing tests. |
|
@meeseeksdev please backport to 4.0.x |
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>

References
The
traceoption was added as a comment in #13909, but #13909 does not mention why it was left as a comment.Playwright docs: https://playwright.dev/docs/trace-viewer
Code changes
Enable
traceso it's easier to debug failing UI tests on CI.User-facing changes
None
Backwards-incompatible changes
None