In defer mode render enough cells to fill the viewport #14865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
even if it takes more than a macro cycle
|
Thanks for making a pull request to jupyterlab! |
fcollonval
commented
Jul 24, 2023
Member
Author
fcollonval
left a comment
fcollonval
left a comment
There was a problem hiding this comment.
bot please run benchmark
Member
Author
|
Benchmark tests are ok in term of cell rendered - what happen (too) often is that the cell toolbar is not always displayed:
So I consider this as good to go. |
fcollonval
deleted the
14608-benchmark-ui-test-fails-since-switching-to-defer-mode
branch
Member
Author
|
@meeseeksdev please backport to 4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Aug 2, 2023
…ll the viewport
Merged
fcollonval
added a commit
that referenced
this pull request
Aug 3, 2023
…wport (#14905) Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
even if it takes more than a macro cycle
References
Fixes #14608
Code changes
In notebook defer rendering mode, cells are rendered to at least fill the viewport before starting rendering on idle time.
User-facing changes
Cells should not pop-up when opening a notebook
Notebook opening time may increase
Backwards-incompatible changes
None