Skip to content

Conversation

@fcollonval
Copy link
Member

References

Fixes #14860

Code changes

None

User-facing changes

Fix documentation link

Backwards-incompatible changes

None

@fcollonval fcollonval linked an issue Jul 20, 2023 that may be closed by this pull request
@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added this to the 3.6.x milestone Jul 20, 2023
@fcollonval fcollonval merged commit 64fca7b into main Jul 20, 2023
@fcollonval fcollonval deleted the 14860-ci-check-links-is-broken-following-the-release-of-notebook-v7 branch July 20, 2023 14:17
@fcollonval
Copy link
Member Author

@meeseeksdev please backport to 4.0.x

@fcollonval
Copy link
Member Author

@meeseeksdev please backport to 3.6.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jul 20, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 3.6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 64fca7b29c9bb7c6470e324fc9982873ebe7e474
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #14861: Fix broken link to security model'
  1. Push to a named branch:
git push YOURFORK 3.6.x:auto-backport-of-pr-14861-on-3.6.x
  1. Create a PR against branch 3.6.x, I would have named this PR:

"Backport PR #14861 on branch 3.6.x (Fix broken link to security model)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

fcollonval added a commit that referenced this pull request Jul 23, 2023
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
@fcollonval fcollonval modified the milestones: 3.6.x, 4.0.x Aug 11, 2023
@fcollonval
Copy link
Member Author

No need to backport as that documentation was added in 4.0.0

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI check links is broken following the release of Notebook v7

2 participants