Fix CodeMirror tooltip positioning and tooltip background #14858
Conversation
|
Thanks for making a pull request to jupyterlab! |
There was a problem hiding this comment.
Thanks @krassowski
in https://github.com/jupyterlab/jupyter-collaboration/blob/a2671b2e226ba8163fb878885305f27ad9c77e3a/packages/collaboration/src/cursors.ts#L432 to allow displaying the user name when collaborating, I also added the parent to be document.body so that the tooltip is displayed outside of its containing widget (for the collaboration example that is needed if the cursor is in the editor first line).
Should we bring that one in also by default?
|
Yes, I think that attaching to body is fine. Though I wonder if we should explore defining |
Thanks for the pointer I oversight that feat'. I guess it would be nice. I'm gonna approved this as we could do a follow-up with that feature. I let you press forward or merge 😉 |
|
@meeseeksdev please backport to 4.0.x |
…tooltip background
…ckground (#14903) Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
2 participants
References
Fixes #14857 and background (see below).
This mostly concerns extensions, core lab does not make use of the built-in CodeMirror tooltips. Since extensions may want to let's fix it. Also, it is a trivial change.
Code changes
contain: strictfor performance reasonsUser-facing changes
Backwards-incompatible changes
None