fix: update blocked extensions uris #14846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
|
Thanks for making a pull request to jupyterlab! |
fcollonval
requested changes
Jul 19, 2023
Member
fcollonval
left a comment
fcollonval
left a comment
There was a problem hiding this comment.
Thanks for this @emmanuel-ferdman
Could you actually change the URL to point to this repository for self containment?
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
fcollonval
approved these changes
Jul 23, 2023
Member
fcollonval
left a comment
fcollonval
left a comment
There was a problem hiding this comment.
Thanks @emmanuel-ferdman
CI failures are not related
Member
|
@meeseeksdev please backport to 4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Jul 23, 2023
fcollonval
pushed a commit
that referenced
this pull request
Jul 24, 2023
Co-authored-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Code changes
PR updates the
$BLOCKED_EXTENSIONS_URISenv to the correctextensions_simple.jsonfile. It moves tomainbranch instead ofmaster(since it's default). It also updates the$ALLOWED_EXTENSIONS_URISenv which is less important because it's commented.User-facing changes
Backwards-incompatible changes