Fix icon and theme/styles for grid in CSV/TSV viewer #14822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes an issue with style being set on content which is not ready and throwing an error.
|
Thanks for making a pull request to jupyterlab! |
Member
Author
|
@meeseeksdev please backport to 4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Jul 19, 2023
fcollonval
pushed a commit
that referenced
this pull request
Jul 23, 2023
…wer (#14859) Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #14250
Code changes
Move spreadsheet icon setter to before
awaitto execute it synchronously - otherwise the icon is set too late (after adding widget to main area and hence too late to get proper class applied) due to async code execution.Also fixes an issue with style being set on content which is not ready and throwing an error by awaiting on initialisation (adds new public
readymember onCSVViewer).User-facing changes
Backwards-incompatible changes
Adds a non-optional API member
readyonCSVViewerclass, we can make it optional on backport.