Adds rank to ICompletionProvider #14800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
krassowski
reviewed
Jul 7, 2023
| * priority to your provider, use a rank of 1000 or above. | ||
| * | ||
| * The rank is optional for backwards compatibility. If the rank is `undefined`, | ||
| * it will assign a rank of [1, 499] making the provider available but with a |
Member
Author
There was a problem hiding this comment.
No, the upper limit is not implemented, but you need 49 providers to reach a rank of 500.
37 tasks
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
fcollonval
approved these changes
Jul 19, 2023
Member
fcollonval
left a comment
fcollonval
left a comment
There was a problem hiding this comment.
Thanks @hbcarlos
I would wait before merging so @krassowski can have another look at this one.
krassowski
requested changes
Jul 19, 2023
Member
krassowski
left a comment
krassowski
left a comment
There was a problem hiding this comment.
The failing tests is relevant:
jupyterlab › test/jupyterlab/completer.test.ts:85:9 › Completer › Notebook › Token completions show up without running the cell when in the same cell
krassowski
approved these changes
Jul 20, 2023
Member
krassowski
left a comment
krassowski
left a comment
There was a problem hiding this comment.
I see the relevant test passing now - thank you!
Member
|
@meeseeksdev please backport to 4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Jul 25, 2023
krassowski
pushed a commit
that referenced
this pull request
Jul 30, 2023
Co-authored-by: Carlos Herrero <26092748+hbcarlos@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
fixes #14790
Code changes
Adds rank to the ICompletionProvider and sets a rank of ~500 to the default providers.
User-facing changes
The default rank of the providers.
Backwards-incompatible changes
N/A