Blur footer for any key that triggers a 'select above', not just ArrowUp #14796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
krassowski
reviewed
Jul 5, 2023
krassowski
reviewed
Jul 8, 2023
krassowski
reviewed
Jul 8, 2023
smacke
changed the title
krassowski
reviewed
Sep 10, 2023
…e selectAbove action
An advantage of this approach is that it will also work with any other footer widgets (i.e. they won't need to implement `onSelectAbove()` which was proposed in previous version).
krassowski
force-pushed
the
fix-footer-shortcut
branch
from
558d0e8 to
21659f7
Compare
Member
|
@smacke can you confirm whether the latest commits solve the problem for you? This way we do not expand our public API, and we only have one shortcut. |
krassowski
approved these changes
Sep 23, 2023
Member
krassowski
left a comment
krassowski
left a comment
There was a problem hiding this comment.
This is good to go from me, but will wait for confirmation from @smacke and potentially any other comments. It would be great to include this PR in next point release.
Contributor
Author
|
Thanks for stepping in @krassowski! I can confirm that with these changes, everything behaves the way I would expect:
|
Member
|
@meeseeksdev please backport to 4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Sep 27, 2023
… 'select above', not just ArrowUp
jtpio
pushed a commit
that referenced
this pull request
Sep 28, 2023
…bove', not just ArrowUp (#15162) Co-authored-by: Stephen Macke <stephen.macke@gmail.com>
Merged
2 tasks
krassowski
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just makes sure that 'k' can still work for navigating after the 'Click to add a cell' footer has been focused.
References
Code changes
User-facing changes
Backwards-incompatible changes