Skip to content

Emit changed signal from output area when an output is updated #14785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fcollonval merged 7 commits into from
Jul 17, 2023
Merged

Emit changed signal from output area when an output is updated #14785

fcollonval merged 7 commits into from
Jul 17, 2023

Conversation

@bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Jul 2, 2023 •
edited
Loading

References

Code changes

  • emit changed from OutputAreaModel when an output is updated with setData (or changes in any other way, presumably)
  • add browser-based acceptance test that verifies changes are updated by e.g. vega

User-facing changes

  • users should see fallback/metadata from mime renderers which use setData

Backwards-incompatible changes

  • ???

@jupyterlab-probot
Copy link

jupyterlab-probot bot commented Jul 2, 2023

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@bollwyvl bollwyvl changed the title Emit changed signal from outut area when an output is updated Emit changed signal from output area when an output is updated Jul 2, 2023
@bollwyvl bollwyvl marked this pull request as ready for review July 2, 2023 16:43
@bollwyvl bollwyvl mentioned this pull request Jul 2, 2023
Merged
15 tasks
@krassowski krassowski added the bug label Jul 5, 2023
krassowski
krassowski reviewed Jul 5, 2023
View reviewed changes
krassowski
krassowski reviewed Jul 5, 2023
View reviewed changes
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Jul 6, 2023

well that was clearly wrong...

@fcollonval fcollonval added this to the 4.0.x milestone Jul 11, 2023
@fcollonval
Copy link
Member

fcollonval commented Jul 13, 2023

Some subtle elements, as the fixture tmpPath is set at the file level, all tests will be executed within the same working folder. So as the file was saved, the initial content changed between the 1st and 2nd test.

I pushed a fix to also use the files API instead of fs as getting the local path is a tough business (the root directory used is a dynamically generated temporary directory).

Hopefully the CI will be green(er 😉)

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Jul 13, 2023 via email

fcollonval
fcollonval approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bollwyvl

@fcollonval
Copy link
Member

fcollonval commented Jul 17, 2023

CI failure are not related

@fcollonval fcollonval merged commit 806fae5 into jupyterlab:main Jul 17, 2023
@fcollonval
Copy link
Member

fcollonval commented Jul 17, 2023

@meeseeksdev please backport to 4.0.x

@meeseeksmachine meeseeksmachine mentioned this pull request Jul 17, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Jul 17, 2023
@bollwyvl @meeseeksmachine
Backport PR jupyterlab#14785: Emit changed signal from output area wh…
377a497 
…en an output is updated
@bollwyvl bollwyvl deleted the gh-14781-mime-setdata branch July 17, 2023 13:39
fcollonval pushed a commit that referenced this pull request Jul 18, 2023
@meeseeksmachine @bollwyvl
Backport PR #14785: Emit changed signal from output area when an outp…
b79dab2 
…ut is updated (#14835)

Co-authored-by: Nicholas Bollweg <nick.bollweg@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@krassowski krassowski krassowski left review comments

@fcollonval fcollonval fcollonval approved these changes

Assignees

@bollwyvl bollwyvl

Labels

bug pkg:outputarea tag:Testing

Projects

None yet

Milestone

4.0.x

Development

Successfully merging this pull request may close these issues.

vega (any?) MIME renderers do not update saved output MIME bundle

3 participants

@bollwyvl @fcollonval @krassowski