Skip to content

Removes context data from shared model #14771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fcollonval merged 1 commit into from
Jul 28, 2023
Merged

Removes context data from shared model #14771

fcollonval merged 1 commit into from
Jul 28, 2023

Conversation

@hbcarlos
Copy link
Member

@hbcarlos hbcarlos commented Jun 29, 2023

Fixes jupyterlab/jupyter-collaboration#165
It might fix #14763

References

Code changes

Removes context data from the shared models

User-facing changes

N/A

Backwards-incompatible changes

@hbcarlos hbcarlos added the bug label Jun 29, 2023
@hbcarlos hbcarlos requested a review from fcollonval June 29, 2023 15:07
@hbcarlos hbcarlos self-assigned this Jun 29, 2023
@jupyterlab-probot
Copy link

jupyterlab-probot bot commented Jun 29, 2023

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@hbcarlos hbcarlos mentioned this pull request Jul 5, 2023
Closed
@fcollonval fcollonval added this to the 4.0.x milestone Jul 18, 2023
fcollonval
fcollonval approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hbcarlos

@fcollonval fcollonval merged commit 19c62e5 into jupyterlab:main Jul 28, 2023
@fcollonval
Copy link
Member

fcollonval commented Jul 28, 2023

@meeseeksdev please backport to 4.0.x

@meeseeksmachine meeseeksmachine mentioned this pull request Jul 28, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Jul 28, 2023
@hbcarlos @meeseeksmachine
Backport PR jupyterlab#14771: Removes context data from shared model
82f4c8e
@hbcarlos hbcarlos deleted the fix_rtc_issue_165 branch July 31, 2023 07:01
fcollonval pushed a commit that referenced this pull request Jul 31, 2023
@meeseeksmachine @hbcarlos
Backport PR #14771: Removes context data from shared model (#14880)
a3e39d6 
Co-authored-by: Carlos Herrero <26092748+hbcarlos@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@hbcarlos hbcarlos

Labels

bug pkg:docregistry

Projects

None yet

Milestone

4.0.x

Development

Successfully merging this pull request may close these issues.

Incorrect file name shown on tab for markdown file Strange behaviour after renaming a file.

2 participants

@hbcarlos @fcollonval