Skip checking for updates in UI tests #14609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
Member
|
@meeseeksdev please backport to 3.6.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
May 30, 2023
fcollonval
added a commit
that referenced
this pull request
May 30, 2023
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Integration tests on old version branches are failing like: https://github.com/jupyterlab/jupyterlab/actions/runs/5057283387/jobs/9075847529?pr=14583
It actually makes sense to disable it by default as extension authors using galata may not always update JupyterLab to the latest version.
Code changes
For integration tests, deactivate check for JupyterLab update.
User-facing changes
None
Backwards-incompatible changes
None