Skip to content

Enable base numbering option #14586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
krassowski merged 1 commit into from
May 28, 2023
Merged

Enable base numbering option #14586

krassowski merged 1 commit into from
May 28, 2023

Conversation

@tuncbkose
Copy link
Contributor

@tuncbkose tuncbkose commented May 24, 2023

References

Closes #14571.

Code changes

User-facing changes

The already-implemented baseNumbering option is now exposed as a configurable setting.

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

jupyterlab-probot bot commented May 24, 2023

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@welcome
Copy link

welcome bot commented May 24, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@tuncbkose
Copy link
Contributor Author

tuncbkose commented May 24, 2023 •
edited
Loading

Forgot doc changes Added now

@tuncbkose
Copy link
Contributor Author

tuncbkose commented May 24, 2023

Failures seem unrelated to me

krassowski
krassowski approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tuncbkose!

@krassowski krassowski added this to the 4.0.x milestone May 24, 2023
@krassowski krassowski merged commit 3fd8c72 into jupyterlab:main May 28, 2023
@welcome
Copy link

welcome bot commented May 28, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@tuncbkose tuncbkose deleted the toc-basenum branch May 28, 2023 11:39
@choies1
Copy link

choies1 commented Sep 28, 2023

Thanks for this feature.

Is it possible to set the base number for each notebook?

@fcollonval
Copy link
Member

fcollonval commented Oct 2, 2023

@choies1 metadata as specified by the old ToC for notebook prior to v7 should work; see that code:

jupyterlab/packages/notebook/src/toc.ts

Lines 460 to 462 in 3e2bbf1

numberHeaders: ['toc-autonumbering', 'toc/number_sections'],
numberingH1: ['!toc/skip_h1_title'],
baseNumbering: ['toc/base_numbering']

Would you mind reporting it works? If so would you be willing to improve the documentation there: https://github.com/jupyterlab/jupyterlab/edit/main/docs/source/user/toc.rst

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@krassowski krassowski krassowski approved these changes

Assignees

@tuncbkose tuncbkose

Labels

documentation enhancement pkg:toc tag:Feature Parity

Projects

None yet

Milestone

4.0.x

Development

Successfully merging this pull request may close these issues.

Please add begin number option in Table of Contents

4 participants

@tuncbkose @choies1 @fcollonval @krassowski