Hide completer when changing notebook tabs #14534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
added 2 commits
May 23, 2023 09:36
…re other mousedown events with preventDefault and stopPropogation
nishikantparmariam
force-pushed
the
fix-completer-not-hiding
branch
from
8fe8de6 to
1f3dc59
Compare
nishikantparmariam
changed the title
krassowski
approved these changes
Sep 23, 2023
Member
krassowski
left a comment
krassowski
left a comment
There was a problem hiding this comment.
This works well for me, I don't think this would cause any trouble with Notebook 7.
I will wait for a second look from @fcollonval as per discussion on the issue: #14496 (comment)
Member
|
Two weeks have passed, no objections - I am merging this because I believe this simply restores previous behaviour after transition from |
Member
|
@meeseeksdev please backport to 4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Oct 7, 2023
krassowski
pushed a commit
that referenced
this pull request
Oct 9, 2023
Co-authored-by: Nishikant Parmar <nishikantparmar123@gmail.com>
Member
|
@meeseeksdev please backport to 3.6.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Oct 9, 2023
krassowski
added a commit
that referenced
this pull request
Oct 18, 2023
… changing notebook tabs) (#15244) * Backport PR #14534: Hide completer when changing notebook tabs * Backport PR #15237: Fix completer tests after transition to pointer events Cherry-picked from commit 206368a. --------- Co-authored-by: Nishikant Parmar <nishikantparmar123@gmail.com> Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Closes #14496