Skip to content

Backport PR #14212 on branch 3.6.x (Fix save as without changing the file name) #14217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fcollonval merged 1 commit into from
Mar 17, 2023
Merged

Backport PR #14212 on branch 3.6.x (Fix save as without changing the file name) #14217

fcollonval merged 1 commit into from
Mar 17, 2023

Conversation

@fcollonval
Copy link
Member

@fcollonval fcollonval commented Mar 17, 2023

Backport PR #14212

@fcollonval
Fix save as without changing the file name (jupyterlab#14212)
3bfe913 
* Fixes saving with the same name

* Review

* Add test for dismissed save as dialog

---------

Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
(cherry picked from commit b80523f)
@jupyterlab-probot
Copy link

jupyterlab-probot bot commented Mar 17, 2023

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added the bug label Mar 17, 2023
@fcollonval fcollonval added this to the 3.6.x milestone Mar 17, 2023
@fcollonval fcollonval merged commit 36f65af into jupyterlab:3.6.x Mar 17, 2023
@fcollonval fcollonval deleted the backport/14212-save-as-fix branch March 17, 2023 15:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@fcollonval fcollonval

Labels

bug pkg:docmanager pkg:docregistry

Projects

None yet

Milestone

3.6.x

Development

Successfully merging this pull request may close these issues.

1 participant

@fcollonval