Skip to content

Update ESLint dependencies #14216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jtpio merged 2 commits into from
Mar 17, 2023
Merged

Update ESLint dependencies #14216

jtpio merged 2 commits into from
Mar 17, 2023

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented Mar 16, 2023

References

Fixes #14158

Code changes

Update the eslint dependencies.

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

jupyterlab-probot bot commented Mar 16, 2023

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@jtpio
Copy link
Member Author

jtpio commented Mar 16, 2023

Running jlpm run eslint from this branch does not seem to be triggering the warning anymore:

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <4.8.0

YOUR TYPESCRIPT VERSION: 5.0.1-rc

Please only submit bug reports when using the officially supported version.

=============

Just the ones from #9392.

image

@jtpio jtpio mentioned this pull request Mar 16, 2023
Merged
@jtpio jtpio added this to the 4.0.0 milestone Mar 16, 2023
@jtpio jtpio marked this pull request as ready for review March 16, 2023 18:21
@jtpio jtpio requested a review from JasonWeill March 16, 2023 18:21
fcollonval
fcollonval approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jtpio jtpio merged commit 02c087f into jupyterlab:master Mar 17, 2023
@jtpio jtpio deleted the update-eslint branch March 17, 2023 08:55
@jtpio jtpio mentioned this pull request Mar 17, 2023
Closed
@krassowski krassowski mentioned this pull request Mar 21, 2023
Merged
1 task
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fcollonval fcollonval fcollonval approved these changes

@JasonWeill JasonWeill Awaiting requested review from JasonWeill

Assignees

@jtpio jtpio

Labels

maintenance pkg:application pkg:apputils pkg:codemirror pkg:docregistry pkg:lsp pkg:notebook pkg:services pkg:statusbar pkg:ui-components

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

eslint does not support TypeScript 5

2 participants

@jtpio @fcollonval