Skip to content

Update to TypeScript 5 final #14215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fcollonval merged 1 commit into from
Mar 17, 2023
Merged

Update to TypeScript 5 final #14215

fcollonval merged 1 commit into from
Mar 17, 2023

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented Mar 16, 2023

References

Fixes #13872

For more info: https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/

Code changes

Update the typescript dependency.

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

jupyterlab-probot bot commented Mar 16, 2023

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@jtpio jtpio added this to the 4.0.0 milestone Mar 16, 2023
@jtpio jtpio requested a review from JasonWeill March 16, 2023 17:41
@JasonWeill
Copy link
Contributor

JasonWeill commented Mar 16, 2023

Is there a way to update eslint to support TS5, to resolve #14158 at the same time?

@jtpio
Copy link
Member Author

jtpio commented Mar 16, 2023

Is there a way to update eslint to support TS5, to resolve #14158 at the same time?

We could probably try it in another PR since #14158 was already affected by the RC releases of TypeScript 5.

@jtpio
Copy link
Member Author

jtpio commented Mar 16, 2023

We could probably try it in another PR

Opened #14216 if you would like to take a look.

jasongrout
jasongrout approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@jasongrout jasongrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 482 <- [551 - 583 - 615] -> 712 634 <- [1109 - 1133 - 1161] -> 1281
expected 465 <- [543 - 568 - 601] -> 922 1027 <- [1104 - 1140 - 1163] -> 1301
Mean relative change 1.7% ± 2.7% -0.6% ± 1.6%
switch-from
chromium
actual 556 <- [622 - 642 - 662] -> 760 260 <- [332 - 356 - 379] -> 438
expected 529 <- [612 - 630 - 650] -> 826 268 <- [320 - 340 - 365] -> 429
Mean relative change 1.4% ± 1.8% 3.3% ± 3.0%
switch-to
chromium
actual 1024 <- [1068 - 1094 - 1123] -> 1323 682 <- [730 - 748 - 766] -> 858
expected 924 <- [1051 - 1078 - 1121] -> 1389 687 <- [728 - 749 - 767] -> 937
Mean relative change 0.9% ± 1.7% -0.3% ± 1.3%
close
chromium
actual 132 <- [145 - 150 - 154] -> 183 179 <- [193 - 197 - 203] -> 284
expected 126 <- [144 - 148 - 152] -> 195 169 <- [189 - 197 - 206] -> 276
Mean relative change 2.2% ± 1.8% 1.0% ± 2.1%

Changes are computed with expected as reference.

@jupyterlab/benchmarks@1.0.0 test:mocha
mocha ./tests/

Waiting for localhost:8888
localhost:8888 is up

Cell memory leaks

Create a code cell Memory change: +160 kB Leak detected: Yes

Leaking objects:

Object # added Retained size increase
ArraySearchMarker 1 +5 B
ContentDeleted 1 +16 B
ContentString 1 +69 B
Detached Text 1 +75 B
FocusTracker 1 +276 B
ObservableList 1 +60 B
OutputArea 1 +1.4 kB
OutputAreaModel 1 +115 B
Promise 1 +20 B
PromiseDelegate 1 +128 B
ResizeHandle 1 +47 B
RestorablePool 1 +304 B
UndoManager 1 +1.93 kB
WidgetTracker 1 +976 B
YArray 1 +164 B
YCodeCell 1 +-12 B
YText 1 +558 B
Detached DOMStringMap 2 +96 B
Detached V8EventHandlerNonNull 2 +80 B
Set 2 +1.21 kB
YMap 2 +464 B
StackItem 3 +1.32 kB
ContentAny 4 +238 B
ContentType 4 +64 B
DeleteItem 4 +80 B
DeleteSet 6 +988 B
Detached HTMLCollection 6 +572 B
EventHandler 8 +250 B
ID 10 +320 B
Item 10 +1.2 kB
Detached DOMTokenList 13 +876 B
Detached Attr 14 +1.01 kB
Detached HTMLDivElement 14 +46.8 kB
Map 17 +2.65 kB
Signal 19 +319 B
Object 35 +32.8 kB
Array 44 +5.67 kB
Detached V8EventListener 263 +23.4 kB
Detached EventListener 265 +42.6 kB
(closure) 270 +28.2 kB
Detached InternalNode 323 +45.2 kB

Leaking collections:

Type Change Preview Size increased at
Array +2 [StackItem, ...] 
UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5030:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4693:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4695:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4810:9 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2023:5
Array +10 [Item, ...] 
addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4268:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:11054:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6617:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6590:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6677:10
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6996:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4796:5 
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6995:7
Set +1 Set((anonymous function), ...) 
                          webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                                                                     
Doc.on                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2182:11                                         
new UndoManager           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5050:14                                         
YCodeCell.setUndoManager  http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:398:33 
<unknown>                 http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1584:15
Array.forEach             <anonymous>                                                                                                                                    
YNotebook.insertCells     http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1583:16
YNotebook.insertCell      http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1564:21
                          webpack://jupyterlab/packages/notebook/src/actions.tsx:404:22
Create a markdown cell Memory change: -98.7 kB Leak detected: No

Leaking objects:

Object # added Retained size increase
ActivityMonitor 1 +294 B
ArraySearchMarker 1 +5 B
AttachmentsModel 1 +193 B
AttachmentsResolver 1 +14 B
CodeCellModel 1 +400 B
ContentString 1 +72 B
Debouncer 1 +3.46 kB
Detached HTMLAnchorElement 1 +312 B
Detached HTMLButtonElement 1 +5.31 kB
Detached HTMLHeadingElement 1 +1.01 kB
Error 1 +3.06 kB
MarkdownCell 1 +4.72 kB
MarkdownCellModel 1 +237 B
Poll 1 +3.7 kB
RenderMimeRegistry 1 +227 B
RenderedMarkdown 1 +66 B
Transaction 1 +860 B
TypeError 1 +301 B
YArray 1 +164 B
YArrayEvent 1 +357 B
YCodeCell 1 +107 B
YMarkdownCell 1 +45 B
Detached CSSStyleDeclaration 2 +124 B
Detached HTMLElement 2 +320 B
Detached V8EventHandlerNonNull 2 +5.04 kB
Promise 2 +3.06 kB
PromiseDelegate 2 +3.27 kB
UndoManager 2 +2.38 kB
YText 2 +501 B
Detached DOMStringMap 3 +136 B
ObservableMap 3 +381 B
StackItem 3 +1.33 kB
DeleteItem 4 +80 B
YMap 4 +872 B
ContentAny 5 +524 B
DeleteSet 6 +1 kB
ContentType 7 +112 B
Detached Text 7 +504 B
Set 8 +1.76 kB
Detached HTMLDivElement 10 +30.5 kB
Detached DOMTokenList 13 +840 B
ID 13 +416 B
Item 13 +1.79 kB
EventHandler 14 +470 B
Detached HTMLCollection 17 +1.81 kB
Map 27 +12.2 kB
Signal 28 +756 B
Detached V8EventListener 130 +10.9 kB
Detached EventListener 132 +25.5 kB
(closure) 152 +16 kB
Detached InternalNode 162 +28.3 kB

Leaking collections:

Type Change Preview Size increased at
Array +1 [{signal, slot, thisArg}, ...] 
Object.connect  http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10490:17
Signal.connect  http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10230:24
                webpack://jupyterlab/packages/notebook/src/notebooktools.ts:226:33         
invokeSlot      http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10699:18
Object.emit     http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10657:17
Signal.emit     http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10256:17
                webpack://jupyterlab/packages/notebook/src/tracker.ts:90:30                
invokeSlot      http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10699:18
Object.emit     http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10657:17
Array +1 [{signal, slot, thisArg}, ...] 
Object.connect  http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10490:17
Signal.connect  http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10230:24
                webpack://jupyterlab/packages/cell-toolbar/src/celltoolbartracker.ts:121:37
invokeSlot      http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10699:18
Object.emit     http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10657:17
Signal.emit     http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10256:17
                webpack://jupyterlab/packages/notebook/src/widget.ts:1321:30               
                webpack://jupyterlab/packages/notebook/src/actions.tsx:408:28              
                webpack://jupyterlab/packages/notebook-extension/src/index.ts:2719:15
Array +1 [54839695-c289-42fb-a319-52078b77741a, ...] 
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2503:37            
Array.forEach                        <anonymous>                                                               
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2498:21            
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:350:12             
                                     webpack://jupyterlab/packages/notebook-extension/src/index.ts:2650:15     
CommandRegistry.execute              http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:5748:33
CommandRegistry._executeKeyBinding   http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:5906:14
CommandRegistry.processKeydownEvent  http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:5846:18
JupyterLab.evtKeydown                http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:4660:23
Array +2 [StackItem, ...] 
UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5030:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4693:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4695:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4810:9 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2023:5
Array +13 [Item, ...] 
addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4268:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:11054:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6617:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6590:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6677:10
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6996:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4796:5 
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6995:7
Set +2 Set((anonymous function), ...) 
                          webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                                                                     
Doc.on                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2182:11                                         
new UndoManager           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5050:14                                         
YCodeCell.setUndoManager  http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:398:33 
<unknown>                 http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1584:15
Array.forEach             <anonymous>                                                                                                                                    
YNotebook.insertCells     http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1583:16
YNotebook.insertCell      http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1564:21
                          webpack://jupyterlab/packages/notebook/src/actions.tsx:404:22
Create a raw cell Memory change: +138 kB Leak detected: Yes

Leaking objects:

Object # added Retained size increase
ArraySearchMarker 1 +5 B
CodeCellModel 1 +359 B
ContentString 1 +690 B
Detached CSSStyleDeclaration 1 +68 B
Detached V8EventHandlerNonNull 1 +40 B
ObservableMap 1 +102 B
TypeError 1 +301 B
YArray 1 +164 B
YCodeCell 1 +107 B
YRawCell 1 +45 B
Detached DOMStringMap 2 +96 B
Set 2 +1.26 kB
UndoManager 2 +2.38 kB
YText 2 +473 B
StackItem 3 +1.33 kB
DeleteItem 4 +80 B
YMap 4 +872 B
ContentAny 5 +490 B
Detached HTMLCollection 5 +488 B
DeleteSet 6 +1 kB
ContentType 7 +112 B
Detached DOMTokenList 9 +628 B
Detached HTMLDivElement 9 +22.7 kB
Signal 11 +450 B
ID 13 +416 B
Item 13 +2.37 kB
EventHandler 14 +453 B
Map 19 +2.85 kB
Detached V8EventListener 130 +10.9 kB
Detached EventListener 131 +20.4 kB
(closure) 140 +20.9 kB
Detached InternalNode 151 +21.7 kB

Leaking collections:

Type Change Preview Size increased at
Array +1 [2baba29b-b442-40ab-92f2-f831d84e7d81, ...] 
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2503:37            
Array.forEach                        <anonymous>                                                               
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2498:21            
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:350:12             
                                     webpack://jupyterlab/packages/notebook-extension/src/index.ts:2650:15     
CommandRegistry.execute              http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:5748:33
CommandRegistry._executeKeyBinding   http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:5906:14
CommandRegistry.processKeydownEvent  http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:5846:18
JupyterLab.evtKeydown                http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:4660:23
Array +1 [{signal, slot, thisArg}, ...] 
Object.connect  http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10490:17
Signal.connect  http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10230:24
                webpack://jupyterlab/packages/cell-toolbar/src/celltoolbartracker.ts:121:37
invokeSlot      http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10699:18
Object.emit     http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10657:17
Signal.emit     http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10256:17
                webpack://jupyterlab/packages/notebook/src/widget.ts:1321:30               
                webpack://jupyterlab/packages/notebook/src/actions.tsx:408:28              
                webpack://jupyterlab/packages/notebook-extension/src/index.ts:2719:15
Array +1 [{signal, slot, thisArg}, ...] 
Object.connect  http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10490:17
Signal.connect  http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10230:24
                webpack://jupyterlab/packages/notebook/src/notebooktools.ts:226:33         
invokeSlot      http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10699:18
Object.emit     http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10657:17
Signal.emit     http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10256:17
                webpack://jupyterlab/packages/notebook/src/tracker.ts:90:30                
invokeSlot      http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10699:18
Object.emit     http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10657:17
Array +2 [StackItem, ...] 
UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5030:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4693:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4695:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4810:9 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2023:5
Array +13 [Item, ...] 
addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4268:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:11054:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6617:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6590:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6677:10
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6996:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4796:5 
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6995:7
Set +2 Set((anonymous function), ...) 
                          webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                                                                     
Doc.on                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2182:11                                         
new UndoManager           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5050:14                                         
YCodeCell.setUndoManager  http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:398:33 
<unknown>                 http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1584:15
Array.forEach             <anonymous>                                                                                                                                    
YNotebook.insertCells     http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1583:16
YNotebook.insertCell      http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1564:21
                          webpack://jupyterlab/packages/notebook/src/actions.tsx:404:22                                                                                  
- Drag and drop a cell

File editor memory leaks

Create a file Memory change: -78.4 kB Leak detected: No

Leaking objects:

Object # added Retained size increase
Detached HTMLUListElement 1 +2.29 kB
Detached V8EventHandlerNonNull 1 +40 B
VirtualElementPass 1 +46 B
Detached HTMLButtonElement 2 +23.7 kB
Detached SVGCircleElement 2 +1.1 kB
HTMLDivElement 2 +97 B
LabIcon 2 +1.07 kB
Detached CSSStyleDeclaration 3 +212 B
Detached HTMLLIElement 3 +5.1 kB
Detached NodeList 3 +192 B
NavigationHistoryEntry 3 +720 B
VirtualText 3 +109 B
Detached SVGGElement 4 +2.94 kB
VirtualElement 4 +1 kB
Detached SVGAnimatedPreserveAspectRatio 5 +320 B
Detached SVGAnimatedRect 5 +320 B
Detached SVGPathElement 5 +1.77 kB
Detached SVGSVGElement 5 +7.89 kB
Detached HTMLSpanElement 6 +2.22 kB
Detached DOMStringMap 7 +352 B
Detached SVGAnimatedNumber 7 +448 B
Detached Attr 10 +720 B
Detached Text 10 +704 B
Detached HTMLCollection 13 +1.41 kB
Detached DOMTokenList 14 +900 B
Detached HTMLDivElement 15 +32.6 kB
Detached SVGAnimatedString 16 +896 B
Detached SVGAnimatedTransformList 16 +1.02 kB
Detached SVGAnimatedLength 26 +1.66 kB
Array 42 +23.6 kB
Detached V8EventListener 130 +10.9 kB
Detached EventListener 131 +20.4 kB
(closure) 140 +17.6 kB
✔ Opening a text file (65145ms)

Notebook memory leaks

Create a notebook Memory change: +29.1 kB Leak detected: Yes

Leaking objects:

Object # added Retained size increase
Detached HTMLUListElement 1 +2.21 kB
Detached V8EventHandlerNonNull 1 +40 B
VirtualElementPass 1 +46 B
Detached HTMLButtonElement 2 +23.4 kB
Detached SVGCircleElement 2 +1.1 kB
HTMLDivElement 2 +17 B
LabIcon 2 +185 B
Detached CSSStyleDeclaration 3 +232 B
Detached HTMLLIElement 3 +5.93 kB
Detached NodeList 3 +204 B
NavigationHistoryEntry 3 +720 B
VirtualText 3 +109 B
VirtualElement 4 +1.18 kB
Detached SVGAnimatedPreserveAspectRatio 5 +320 B
Detached SVGAnimatedRect 5 +320 B
Detached SVGSVGElement 5 +9.27 kB
Detached HTMLSpanElement 6 +3.06 kB
Detached SVGGElement 6 +4.9 kB
Detached SVGPathElement 7 +2.47 kB
Detached SVGAnimatedNumber 9 +576 B
Detached Attr 10 +720 B
Detached Text 10 +688 B
Detached HTMLCollection 13 +1.33 kB
Detached DOMTokenList 15 +988 B
Detached HTMLDivElement 15 +33.1 kB
Detached SVGAnimatedString 20 +1.12 kB
Detached SVGAnimatedTransformList 20 +1.28 kB
DOMRectReadOnly 22 +1.23 kB
Detached SVGAnimatedLength 26 +1.66 kB
Object 58 +192 kB
Detached V8EventListener 130 +10.9 kB
Detached EventListener 131 +20.4 kB
(closure) 138 +34.3 kB

1 passing (6m)
1 pending
2 failing

   Adding a cell:

  Create a code cell - Objects leaking
  + expected - actual

  -1357
  +1308
  
  at file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:43:16
  at Array.forEach (<anonymous>)
  at expectNoLeaks (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:28:11)
  at testScenario (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:230:3)
  at async Context.<anonymous> (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/cell.test.mjs:7:5)


   Opening a notebook:

  Create a notebook - Objects leaking
  + expected - actual

  -681
  +672
  
  at file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:43:16
  at Array.forEach (<anonymous>)
  at expectNoLeaks (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:28:11)
  at testScenario (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:230:3)
  at async Context.<anonymous> (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/notebook.test.mjs:6:5)

@fcollonval fcollonval merged commit c5e0d1e into jupyterlab:master Mar 17, 2023
@jtpio jtpio deleted the ts5-final branch March 17, 2023 08:15
@jtpio jtpio mentioned this pull request Mar 17, 2023
Merged
@krassowski krassowski mentioned this pull request Mar 21, 2023
Merged
1 task
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jasongrout jasongrout jasongrout approved these changes

+1 more reviewer

@JasonWeill JasonWeill JasonWeill approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jtpio jtpio

Labels

enhancement maintenance pkg:application pkg:apputils pkg:attachments pkg:cell-toolbar pkg:cells pkg:celltags pkg:codeeditor pkg:codemirror pkg:completer pkg:console pkg:coreutils pkg:csvviewer pkg:debugger pkg:docmanager pkg:docregistry pkg:documentsearch pkg:extensionmanager pkg:filebrowser pkg:fileeditor pkg:help pkg:htmlviewer pkg:hub pkg:imageviewer pkg:inspector pkg:javascript pkg:json pkg:launcher pkg:logconsole pkg:lsp pkg:mainmenu pkg:markdownviewer pkg:mathjax pkg:notebook pkg:observables pkg:outputarea pkg:pdf pkg:property-inspector pkg:rendermime pkg:running pkg:services pkg:settingeditor pkg:settingregistry pkg:shortcuts pkg:statedb pkg:statusbar pkg:terminal pkg:themes pkg:toc pkg:tooltip pkg:translation pkg:ui-components pkg:vega tag:Examples tag:Testing

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

Update to TypeScript 5 final

4 participants

@jtpio @JasonWeill @jasongrout @fcollonval