Update jupyter-lsp and associated schema #14208

fcollonval · 2023-03-16T09:27:15Z

References

Fix #14206

Code changes

Bump jupyter-lsp to v2 and update associated schema

User-facing changes

None

Backwards-incompatible changes

None

jupyterlab-probot · 2023-03-16T09:27:18Z

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link:

github-actions · 2023-03-16T13:30:28Z

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table

Test file	large_code_notebook	large_md_notebook
open
`chromium`
actual	720 <- [796 - 826 - 844] -> 927	797 <- [1444 - 1538 - 1594] -> 1796
expected	699 <- [777 - 808 - 839] -> 1113	698 <- [1315 - 1550 - 1602] -> 1776
Mean relative change	⚠️ 1.1% ± 1.8%	⚠️ 0.8% ± 5.9%
switch-from
`chromium`
actual	785 <- [835 - 855 - 872] -> 915	328 <- [398 - 424 - 443] -> 551
expected	748 <- [835 - 850 - 870] -> 1057	338 <- [404 - 418 - 451] -> 559
Mean relative change	⚠️ -0.3% ± 1.3%	⚠️ -0.5% ± 2.6%
switch-to
`chromium`
actual	1483 <- [1555 - 1579 - 1622] -> 1786	1012 <- [1068 - 1084 - 1116] -> 1210
expected	1414 <- [1532 - 1547 - 1573] -> 1856	1018 <- [1065 - 1088 - 1119] -> 1229
Mean relative change	⚠️ 2.3% ± 1.1%	⚠️ 0.1% ± 1.0%
close
`chromium`
actual	174 <- [194 - 204 - 214] -> 241	242 <- [271 - 284 - 296] -> 338
expected	169 <- [190 - 197 - 211] -> 254	240 <- [274 - 284 - 296] -> 383
Mean relative change	⚠️ 2.6% ± 2.1%	⚠️ -0.5% ± 1.9%

Changes are computed with expected as reference.

@jupyterlab/benchmarks@1.0.0 test:mocha
mocha ./tests/

Waiting for localhost:8888
localhost:8888 is up

Cell memory leaks

Create a code cell

Memory change: +147 kB Leak detected: Yes

Leaking objects:

Object	# added	Retained size increase
ArraySearchMarker	1	+5 B
ContentDeleted	1	+16 B
ContentString	1	+69 B
Detached Text	1	+69 B
FocusTracker	1	+276 B
ObservableList	1	+60 B
OutputArea	1	+1.4 kB
OutputAreaModel	1	+115 B
Promise	1	+20 B
PromiseDelegate	1	+128 B
ResizeHandle	1	+47 B
RestorablePool	1	+304 B
UndoManager	1	+1.93 kB
WidgetTracker	1	+976 B
YArray	1	+164 B
YCodeCell	1	+107 B
YText	1	+-52 B
Detached DOMStringMap	2	+88 B
Detached V8EventHandlerNonNull	2	+80 B
Set	2	+1.21 kB
YMap	2	+464 B
StackItem	3	+1.32 kB
ContentAny	4	+238 B
ContentType	4	+64 B
DeleteItem	4	+80 B
DeleteSet	6	+988 B
Detached HTMLCollection	6	+560 B
EventHandler	8	+239 B
ID	10	+320 B
Item	10	+1.2 kB
Detached DOMTokenList	13	+824 B
Detached Attr	14	+1.01 kB
Detached HTMLDivElement	14	+46.7 kB
Map	17	+2.56 kB
Signal	19	+319 B
Object	35	+70.4 kB
Array	44	+14.5 kB
Detached V8EventListener	263	+23.4 kB
Detached EventListener	265	+42.6 kB
(closure)	270	+21.7 kB
Detached InternalNode	323	+45.1 kB

Leaking collections:

Type

Change

Preview

Size increased at

Array

+2

[StackItem, ...]

UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5030:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4693:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4695:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4810:9 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2023:5

Array

+10

[Item, ...]

addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4268:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:11054:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6617:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6590:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6677:10
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6996:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4796:5 
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6995:7

Set

+1

Set((anonymous function), ...)

                          webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                                                                     
Doc.on                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2182:11                                         
new UndoManager           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5050:14                                         
YCodeCell.setUndoManager  http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:398:33 
<unknown>                 http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1584:15
Array.forEach             <anonymous>                                                                                                                                    
YNotebook.insertCells     http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1583:16
YNotebook.insertCell      http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1564:21
                          webpack://jupyterlab/packages/notebook/src/actions.tsx:404:22

Create a markdown cell

Memory change: -112 kB Leak detected: No

Leaking objects:

Object	# added	Retained size increase
ActivityMonitor	1	+294 B
ArraySearchMarker	1	+5 B
AttachmentsModel	1	+193 B
AttachmentsResolver	1	+14 B
CodeCellModel	1	+177 B
ContentString	1	+72 B
Debouncer	1	+3.46 kB
Detached HTMLAnchorElement	1	+312 B
Detached HTMLButtonElement	1	+5.31 kB
Detached HTMLHeadingElement	1	+1 kB
Error	1	+3.06 kB
MarkdownCell	1	+4.72 kB
MarkdownCellModel	1	+237 B
Poll	1	+3.7 kB
RenderMimeRegistry	1	+227 B
RenderedMarkdown	1	+66 B
Transaction	1	+860 B
TypeError	1	+306 B
YArray	1	+164 B
YArrayEvent	1	+357 B
YCodeCell	1	+114 B
YMarkdownCell	1	+45 B
Detached CSSStyleDeclaration	2	+124 B
Detached HTMLElement	2	+320 B
Detached V8EventHandlerNonNull	2	+5.04 kB
Promise	2	+3.06 kB
PromiseDelegate	2	+3.27 kB
UndoManager	2	+2.36 kB
YText	2	+484 B
Detached DOMStringMap	3	+148 B
ObservableMap	3	+381 B
StackItem	3	+1.3 kB
DeleteItem	4	+80 B
YMap	4	+872 B
ContentAny	5	+487 B
DeleteSet	6	+976 B
ContentType	7	+112 B
Detached Text	7	+504 B
Set	8	+1.79 kB
Detached HTMLDivElement	10	+30.6 kB
Detached DOMTokenList	13	+852 B
ID	13	+260 B
Item	13	+1.62 kB
EventHandler	14	+453 B
Detached HTMLCollection	17	+1.83 kB
Map	27	+12 kB
Signal	28	+594 B
Detached V8EventListener	130	+10.9 kB
Detached EventListener	132	+25.5 kB
(closure)	152	+14.7 kB
Detached InternalNode	162	+28.4 kB

Leaking collections:

Type	Change	Preview	Size increased at
Array	+1	[{signal, slot, thisArg}, ...]	Object.connect http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10490:17 Signal.connect http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10230:24 webpack://jupyterlab/packages/notebook/src/notebooktools.ts:226:33 invokeSlot http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10699:18 Object.emit http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10657:17 Signal.emit http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10256:17 webpack://jupyterlab/packages/notebook/src/tracker.ts:90:30 invokeSlot http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10699:18 Object.emit http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10657:17
Array	+1	[398b97cd-0642-4266-b8a1-1e58a55b7dc9, ...]	webpack://jupyterlab/packages/notebook/src/actions.tsx:2425:37 Array.forEach <anonymous> webpack://jupyterlab/packages/notebook/src/actions.tsx:2420:21 webpack://jupyterlab/packages/notebook/src/actions.tsx:350:12 webpack://jupyterlab/packages/notebook-extension/src/index.ts:2573:15 CommandRegistry.execute http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:5748:33 CommandRegistry._executeKeyBinding http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:5906:14 CommandRegistry.processKeydownEvent http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:5846:18 JupyterLab.evtKeydown http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:4660:23
Array	+1	[{signal, slot, thisArg}, ...]	Object.connect http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10490:17 Signal.connect http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10230:24 webpack://jupyterlab/packages/cell-toolbar/src/celltoolbartracker.ts:121:37 invokeSlot http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10699:18 Object.emit http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10657:17 Signal.emit http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10256:17 webpack://jupyterlab/packages/notebook/src/widget.ts:1321:30 webpack://jupyterlab/packages/notebook/src/actions.tsx:408:28 webpack://jupyterlab/packages/notebook-extension/src/index.ts:2642:15
Array	+2	[StackItem, ...]	UndoManager.afterTransactionHandler http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5030:15 webpack://jupyterlab/node_modules/lib0/observable.js:73:62 Array.forEach <anonymous> webpack://jupyterlab/node_modules/lib0/observable.js:73:62 Array.<anonymous> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4693:27 webpack://jupyterlab/node_modules/lib0/function.js:19:0 cleanupTransactions http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4695:62 transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4810:9 Doc.transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2023:5
Array	+13	[Item, ...]	addStruct http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4268:11 Item.integrate http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:11054:7 <unknown> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6617:22 Array.forEach <anonymous> typeListInsertGenericsAfter http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6590:11 typeListInsertGenerics http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6677:10 <unknown> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6996:9 transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4796:5 YArray.insert http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6995:7
Set	+2	Set((anonymous function), ...)	webpack://jupyterlab/node_modules/lib0/observable.js:30:56 Doc.on http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2182:11 new UndoManager http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5050:14 YCodeCell.setUndoManager http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:398:33 <unknown> http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1584:15 Array.forEach <anonymous> YNotebook.insertCells http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1583:16 YNotebook.insertCell http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1564:21 webpack://jupyterlab/packages/notebook/src/actions.tsx:404:22

Create a raw cell

Memory change: +133 kB Leak detected: Yes

Leaking objects:

Object	# added	Retained size increase
ArraySearchMarker	1	+5 B
CodeCellModel	1	+400 B
ContentString	1	+690 B
Detached CSSStyleDeclaration	1	+60 B
Detached V8EventHandlerNonNull	1	+40 B
ObservableMap	1	+102 B
TypeError	1	+301 B
YArray	1	+164 B
YCodeCell	1	+107 B
YRawCell	1	+45 B
Detached DOMStringMap	2	+96 B
Set	2	+1.26 kB
UndoManager	2	+2.38 kB
YText	2	+686 B
StackItem	3	+1.33 kB
DeleteItem	4	+80 B
YMap	4	+872 B
ContentAny	5	+417 B
Detached HTMLCollection	5	+468 B
DeleteSet	6	+1 kB
ContentType	7	+112 B
Detached DOMTokenList	9	+552 B
Detached HTMLDivElement	9	+22.5 kB
Signal	11	+484 B
ID	13	+416 B
Item	13	+2.3 kB
EventHandler	14	+442 B
Map	19	+2.91 kB
Detached V8EventListener	130	+10.9 kB
Detached EventListener	131	+20.4 kB
(closure)	140	+16.4 kB
Detached InternalNode	151	+21.6 kB

Leaking collections:

Type	Change	Preview	Size increased at
Array	+1	[{signal, slot, thisArg}, ...]	Object.connect http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10490:17 Signal.connect http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10230:24 webpack://jupyterlab/packages/cell-toolbar/src/celltoolbartracker.ts:121:37 invokeSlot http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10699:18 Object.emit http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10657:17 Signal.emit http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10256:17 webpack://jupyterlab/packages/notebook/src/widget.ts:1321:30 webpack://jupyterlab/packages/notebook/src/actions.tsx:408:28 webpack://jupyterlab/packages/notebook-extension/src/index.ts:2642:15
Array	+1	[897939c9-ec28-4881-b966-c86850824db5, ...]	webpack://jupyterlab/packages/notebook/src/actions.tsx:2425:37 Array.forEach <anonymous> webpack://jupyterlab/packages/notebook/src/actions.tsx:2420:21 webpack://jupyterlab/packages/notebook/src/actions.tsx:350:12 webpack://jupyterlab/packages/notebook-extension/src/index.ts:2573:15 CommandRegistry.execute http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:5748:33 CommandRegistry._executeKeyBinding http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:5906:14 CommandRegistry.processKeydownEvent http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:5846:18 JupyterLab.evtKeydown http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:4660:23
Array	+1	[{signal, slot, thisArg}, ...]	Object.connect http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10490:17 Signal.connect http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10230:24 webpack://jupyterlab/packages/notebook/src/notebooktools.ts:226:33 invokeSlot http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10699:18 Object.emit http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10657:17 Signal.emit http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10256:17 webpack://jupyterlab/packages/notebook/src/tracker.ts:90:30 invokeSlot http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10699:18 Object.emit http://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10657:17
Array	+2	[StackItem, ...]	UndoManager.afterTransactionHandler http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5030:15 webpack://jupyterlab/node_modules/lib0/observable.js:73:62 Array.forEach <anonymous> webpack://jupyterlab/node_modules/lib0/observable.js:73:62 Array.<anonymous> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4693:27 webpack://jupyterlab/node_modules/lib0/function.js:19:0 cleanupTransactions http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4695:62 transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4810:9 Doc.transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2023:5
Array	+13	[Item, ...]	addStruct http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4268:11 Item.integrate http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:11054:7 <unknown> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6617:22 Array.forEach <anonymous> typeListInsertGenericsAfter http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6590:11 typeListInsertGenerics http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6677:10 <unknown> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6996:9 transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4796:5 YArray.insert http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6995:7
Set	+2	Set((anonymous function), ...)	webpack://jupyterlab/node_modules/lib0/observable.js:30:56 Doc.on http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2182:11 new UndoManager http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5050:14 YCodeCell.setUndoManager http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:398:33 <unknown> http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1584:15 Array.forEach <anonymous> YNotebook.insertCells http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1583:16 YNotebook.insertCell http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1564:21 webpack://jupyterlab/packages/notebook/src/actions.tsx:404:22

- Drag and drop a cell

File editor memory leaks

Create a file

Memory change: -76.9 kB Leak detected: No

Leaking objects:

Object	# added	Retained size increase
Detached HTMLUListElement	1	+3.11 kB
Detached V8EventHandlerNonNull	1	+40 B
VirtualElementPass	1	+46 B
Detached HTMLButtonElement	2	+23.7 kB
Detached SVGCircleElement	2	+1.1 kB
LabIcon	2	+1.07 kB
Detached CSSStyleDeclaration	3	+228 B
Detached HTMLLIElement	3	+5.92 kB
Detached NodeList	3	+204 B
NavigationHistoryEntry	3	+720 B
VirtualText	3	+109 B
Detached SVGGElement	4	+2.94 kB
VirtualElement	4	+1.01 kB
Detached SVGAnimatedPreserveAspectRatio	5	+320 B
Detached SVGAnimatedRect	5	+320 B
Detached SVGPathElement	5	+1.77 kB
Detached SVGSVGElement	5	+8.02 kB
Detached HTMLSpanElement	6	+2.32 kB
Detached DOMStringMap	7	+424 B
Detached SVGAnimatedNumber	7	+448 B
Detached Attr	10	+720 B
Detached Text	10	+916 B
Detached HTMLCollection	13	+1.42 kB
Detached DOMTokenList	14	+928 B
Detached HTMLDivElement	15	+33.5 kB
Detached SVGAnimatedString	16	+896 B
Detached SVGAnimatedTransformList	16	+1.02 kB
Detached SVGAnimatedLength	26	+1.66 kB
Array	42	+23 kB
Detached V8EventListener	130	+10.9 kB
Detached EventListener	131	+20.4 kB
(closure)	138	+19.1 kB

✔ Opening a text file (65535ms)

Notebook memory leaks

Create a notebook

Memory change: +28.5 kB Leak detected: Yes

Leaking objects:

Object	# added	Retained size increase
Detached HTMLUListElement	1	+2.24 kB
Detached V8EventHandlerNonNull	1	+40 B
VirtualElementPass	1	+46 B
Detached HTMLButtonElement	2	+23.4 kB
Detached SVGCircleElement	2	+1.1 kB
HTMLDivElement	2	+106 B
LabIcon	2	+109 B
Detached CSSStyleDeclaration	3	+252 B
Detached HTMLLIElement	3	+5.88 kB
Detached NodeList	3	+240 B
NavigationHistoryEntry	3	+720 B
VirtualText	3	+105 B
VirtualElement	4	+1.14 kB
Detached SVGAnimatedPreserveAspectRatio	5	+320 B
Detached SVGAnimatedRect	5	+320 B
Detached SVGSVGElement	5	+9.27 kB
Detached HTMLSpanElement	6	+2.96 kB
Detached SVGGElement	6	+4.9 kB
Detached SVGPathElement	7	+2.47 kB
Detached SVGAnimatedNumber	9	+576 B
Detached Attr	10	+720 B
Detached Text	10	+688 B
Detached HTMLCollection	13	+1.35 kB
Detached DOMTokenList	15	+1.02 kB
Detached HTMLDivElement	15	+33.3 kB
Detached SVGAnimatedString	20	+1.12 kB
Detached SVGAnimatedTransformList	20	+1.28 kB
Detached SVGAnimatedLength	26	+1.66 kB
Detached V8EventListener	130	+10.9 kB
Detached EventListener	131	+20.4 kB
(closure)	138	+30.4 kB

✔ Opening a notebook (68363ms)

2 passing (6m)
1 pending
1 failing

   Adding a cell:

  Create a code cell - Objects leaking
  + expected - actual

  -1357
  +1308
  
  at file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:43:16
  at Array.forEach (<anonymous>)
  at expectNoLeaks (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:28:11)
  at testScenario (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:230:3)
  at async Context.<anonymous> (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/cell.test.mjs:7:5)

Update jupyter-lsp and associated schema

40f5950

fcollonval added the bug label Mar 16, 2023

fcollonval added this to the 4.0.0 milestone Mar 16, 2023

fcollonval requested review from krassowski and trungleduc March 16, 2023 09:27

github-actions bot added the pkg:lsp label Mar 16, 2023

github-actions bot assigned fcollonval Mar 16, 2023

trungleduc approved these changes Mar 16, 2023

View reviewed changes

brichet mentioned this pull request Mar 16, 2023

Fix 'completer with doc panel' UI test #14214

Merged

fcollonval merged commit 946e17a into jupyterlab:master Mar 17, 2023

fcollonval deleted the fix/14206-LSP-Jest-unit-tests-are-failing branch March 17, 2023 07:08

github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Update jupyter-lsp and associated schema #14208

Update jupyter-lsp and associated schema #14208

Uh oh!

fcollonval commented Mar 16, 2023

Uh oh!

jupyterlab-probot bot commented Mar 16, 2023

Uh oh!

github-actions bot commented Mar 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Update jupyter-lsp and associated schema #14208

Update jupyter-lsp and associated schema #14208

Uh oh!

Conversation

fcollonval commented Mar 16, 2023

References

Code changes

User-facing changes

Backwards-incompatible changes

Uh oh!

jupyterlab-probot bot commented Mar 16, 2023

Uh oh!

github-actions bot commented Mar 16, 2023

Benchmark report

Cell memory leaks

File editor memory leaks

Notebook memory leaks

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants