Skip to content

Rename @jupyterlab/completer-extension:tracker to @jupyterlab/completer-extension:manager #13910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fcollonval merged 1 commit into from
Feb 3, 2023
Merged

Rename @jupyterlab/completer-extension:tracker to @jupyterlab/completer-extension:manager #13910

fcollonval merged 1 commit into from
Feb 3, 2023

Conversation

@fcollonval
Copy link
Member

@fcollonval fcollonval commented Feb 2, 2023

References

Fixes #13669

Code changes

Rename @jupyterlab/completer-extension:tracker to @jupyterlab/completer-extension:manager

I did not update the migration note as this was the name in 3.6.x

User-facing changes

None

Backwards-incompatible changes

None

@fcollonval fcollonval linked an issue Feb 2, 2023 that may be closed by this pull request
Completer manager plugin is named :tracker but probably should be :manager #13669
Closed
@jupyterlab-probot
Copy link

jupyterlab-probot bot commented Feb 2, 2023

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added this to the 4.0.0 milestone Feb 2, 2023
krassowski
krassowski approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcollonval fcollonval merged commit 013b6ab into master Feb 3, 2023
@fcollonval fcollonval deleted the 13669-completer-manager-plugin-is-named-tracker-but-probably-should-be-manager branch February 3, 2023 08:49
@jtpio jtpio mentioned this pull request Feb 14, 2023
Merged
9 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@krassowski krassowski krassowski approved these changes

Assignees

@fcollonval fcollonval

Labels

maintenance pkg:completer tag:Testing

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

Completer manager plugin is named :tracker but probably should be :manager

3 participants

@fcollonval @krassowski