Improve Galata #13909
Merged
Improve Galata #13909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
github-actions
bot
added
Design System CSS
documentation
pkg:application
pkg:apputils
tag:CSS
fcollonval
commented
Feb 2, 2023
Member
Author
|
|
for more information, see https://pre-commit.ci
Member
|
Thanks this looks good 👍 The lint CI failure looks relevant though:
|
Member
Author
|
Thanks for the review @jtpio I fix the linter errors. |
Member
|
Restarting the check release check, not sure it's relevant:
|
Member
|
Looks like the check is now passing:
Maybe we'll want to get #13931 in first, to make sure the UI tests checks pass and this PR doesn't introduce regressions. |
Member
Author
|
Merging to move forward - I keep working on #13931 |
This was referenced Feb 14, 2023
Merged
This was referenced Feb 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Extract improvement of Galata from #13240
Code changes
The major change in Galata is the switch from runtime injection of the helper to a regular JupyterLab extension. This allows to get the helpers in the same namespace as JupyterLab - hence it gives us access to some non-token based elements like
Dialogs.Building on that, this introduces the ability to register listener to dialog and notifications events to make tests more robust; e.g. sometimes a test can be flaky because randomly some dialogs get in the way; with the new listener you could dismissed any random dialogs that may appear.
Adds new fixture
mockUserto mock the user provided by the identity endpoint.It renames
window.galataiptowindow.galataas the later ip is not easy to comprehend (it stands for in-page).As the in-page helpers are now part of an extension, the server setup needs to evolve to add that extra extension. To ease future evolution of the server setup, a new helper
jupyterlab.galata.configure_jupyter_serveris provided.User-facing changes
None
Backwards-incompatible changes
Remove
JupyterLab.notificationManagertrick used up to now to get access to notifications.window.galataipis deprecated in favor ofwindow.galata