Skip to content

Improve kernels pane in running sidebar #13851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fcollonval merged 22 commits into from
Jan 31, 2023
Merged

Improve kernels pane in running sidebar #13851

fcollonval merged 22 commits into from
Jan 31, 2023

Conversation

@afshin
Copy link
Member

@afshin afshin commented Jan 24, 2023 •
edited
Loading

This PR:

  • Updates the notebook:create-new command to support passing in an optional kernelId to create a new notebook that uses an existing kernel instance.
  • Adds a context menu to the kernels pane in the running sidebar that allows users to:
    • Create a new code console for the given kernel
    • Create a new notebook for the given kernel
    • Switch to an existing session connection for the given kernel
    • Shut down the given kernel
  • Adds a collapsible list of connected sessions beneath each kernel in the running kernels pane
  • Displays the icon in the kernel spec's resources instead of displaying the Jupyter icon when possible

References

Code changes

User-facing changes

running.kernels.mov

Backwards-incompatible changes

N/A

@afshin afshin added this to the 4.0.0 milestone Jan 24, 2023
@afshin afshin self-assigned this Jan 24, 2023
@jupyterlab-probot
Copy link

jupyterlab-probot bot commented Jan 24, 2023

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@afshin afshin mentioned this pull request Jan 24, 2023
Closed
@github-actions github-actions bot added Design System CSS tag:CSS For general CSS related issues and pecadilloes labels Jan 24, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 24, 2023
View reviewed changes
@jupyterlab jupyterlab deleted a comment from github-actions bot Jan 25, 2023
@afshin afshin closed this Jan 25, 2023
@afshin afshin reopened this Jan 25, 2023
@afshin
Copy link
Member Author

afshin commented Jan 25, 2023

bot please update documentation snapshots

@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2023

Documentation snapshots updated.

@afshin afshin marked this pull request as ready for review January 25, 2023 19:08
@afshin
Copy link
Member Author

afshin commented Jan 25, 2023

bot please update snapshots

@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2023

Documentation snapshots updated.

@afshin afshin closed this Jan 25, 2023
@afshin afshin reopened this Jan 25, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 26, 2023
View reviewed changes
@afshin
Copy link
Member Author

afshin commented Jan 27, 2023

@fcollonval, thanks for the review!

The only place I'm finding a selector in the docs is for #jp-running-sessions, which still exists. I think I am not looking in the right place 🫤

@jtpio
Copy link
Member

jtpio commented Jan 27, 2023

Thanks @afshin for working on this!

I just tried the latest changes on this branch it's looking good.

Quick question: should a new console started with "New Console for Notebook" also be listed under the kernel? Similar to when a separate console is started and then its kernel changed to an existing one:

kernel-console.mp4

@afshin
Copy link
Member Author

afshin commented Jan 27, 2023

@jtpio yeah I noticed that too. I think because I'm only giving the create console command a kernel ID, it's generating a new Jupyter session (again, such a confusing name for this concept) whereas the one from the notebook's context menu must be passing more info, maybe the session ID or a path.

What do you think the behavior should be? I think it should appear in the list as well. But I don't know if there is a counterargument against that position.

@jtpio
Copy link
Member

jtpio commented Jan 27, 2023

I think it should appear in the list as well.

Same here. In the example above I would expect the new console started from the Untitled.ipynb notebook to also be listed under the kernel, with Untitled.ipynb as the name and with the console icon.

@fcollonval
Copy link
Member

fcollonval commented Jan 27, 2023

The only place I'm finding a selector in the docs is for #jp-running-sessions, which still exists. I think I am not looking in the right place 🫤

To fix some tests with the first PR, I changed some selectors to use the text content (it is considered better for integration tests). There are two places:

jupyterlab/galata/test/documentation/general.test.ts

Line 144 in 0250b69

await page.locator('text="Python 3 (ipykernel) {1}"').waitFor();

jupyterlab/galata/test/documentation/general.test.ts

Line 465 in 0250b69

await expect(page.locator('text="Python 3 (ipykernel) {1}"')).toHaveCount(

As now the text is Python 3 (ipykernel), it is similar to the text use in the kernel status of the notebook. So the selector should be something like:

page.locator('#jp-running-sessions >> text="Python 3 (ipykernel)"')

If you want to read more about the selection in playwright, the doc is over there

@afshin
Copy link
Member Author

afshin commented Jan 27, 2023

bot please update snapshots

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2023

Documentation snapshots updated.

@afshin afshin closed this Jan 27, 2023
@afshin afshin reopened this Jan 27, 2023
@fcollonval
Copy link
Member

fcollonval commented Jan 30, 2023

bot please update documentation snapshots

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2023

Documentation snapshots updated.

fcollonval
fcollonval approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @afshin

@fcollonval fcollonval merged commit e3d4621 into jupyterlab:master Jan 31, 2023
@fcollonval fcollonval mentioned this pull request Feb 2, 2023
Closed
@jtpio
Copy link
Member

jtpio commented Feb 6, 2023

Looks good, thanks!

This was referenced Feb 8, 2023
Closed
Merged
@davidbrochart davidbrochart mentioned this pull request May 14, 2023
Closed
@jtpio jtpio mentioned this pull request Sep 12, 2023
Merged
37 tasks
@krassowski krassowski mentioned this pull request Oct 23, 2023
Closed
@krassowski krassowski mentioned this pull request Oct 31, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@afshin afshin

Labels

Design System CSS enhancement pkg:notebook pkg:running tag:CSS For general CSS related issues and pecadilloes tag:Testing

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@afshin @jtpio @fcollonval