Skip to content

Conversation

@fcollonval
Copy link
Member

References

Follow-up of #12926

jupyter-server v2 is not compatible with Binder. This fixes it.

Code changes

Start JupyterLab with Jupyter Server and not via Jupyter Notebook in Binder.

User-facing changes

N/A

Backwards-incompatible changes

N/A

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added this to the 3.6.0 milestone Oct 31, 2022
@fcollonval fcollonval marked this pull request as ready for review October 31, 2022 10:51
@fcollonval fcollonval merged commit 7782a67 into master Oct 31, 2022
@fcollonval fcollonval deleted the fix/binder-dev branch October 31, 2022 10:52
@fcollonval
Copy link
Member Author

@meeseeksdev please backport to 3.6.x

@lumberbot-app
Copy link

lumberbot-app bot commented Oct 31, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 3.6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 7782a67a7cd41873ca44ff31a29efb5e9f7d13c5
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #13344: Fix Binder for jupyter-server v2'
  1. Push to a named branch:
git push YOURFORK 3.6.x:auto-backport-of-pr-13344-on-3.6.x
  1. Create a PR against branch 3.6.x, I would have named this PR:

"Backport PR #13344 on branch 3.6.x (Fix Binder for jupyter-server v2)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants