Backport of "Allow empty notebook" (#13141) #13296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
* Allows empty notebook * Modify command insertBelow and insertAbove, allow activeCell None in NotebookAdapter and NotebookTrustStatus * Fixes integrity check and linting * Add cell when the notebook is empty in non collaborative mode * Fixes notebook tests * Improves adding a new cell when the notebook is empty in non collaborative mode * Adds a message to the notebook, just in case we end with an empty notebook * Review * Fixes
martinRenou
force-pushed
the
backport_empty_notebook
branch
from
b9bd913 to
7597c85
Compare
Member
|
Is this ready for review? |
Member
|
Great! |
hbcarlos
approved these changes
Oct 26, 2022
Member
hbcarlos
left a comment
hbcarlos
left a comment
There was a problem hiding this comment.
Thanks, @martinRenou. LGTM!
There are some errors on the dev console but they are not related to this PR. I already opened a PR to fix them here #13308
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #13141