Skip to content

Update to TypeScript 4.9 #13028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jtpio wants to merge 1 commit into from
Closed

Update to TypeScript 4.9 #13028

jtpio wants to merge 1 commit into from

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented Aug 30, 2022 •
edited
Loading

References

See the announcement blog post: https://devblogs.microsoft.com/typescript/announcing-typescript-4-8

Code changes

User-facing changes

None

Backwards-incompatible changes

None

@jtpio jtpio added this to the 4.0.0 milestone Aug 30, 2022
@jupyterlab-probot
Copy link

jupyterlab-probot bot commented Aug 30, 2022

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

jtpio added a commit to jtpio/jupyterlab that referenced this pull request Jan 4, 2023
@jtpio
Enable skipLibCheck in @jupyterlab/galata for now
2d44640 
Skip lib check for now while waiting for vega/vega-lite#8473
See the discussion in jupyterlab#13028 for more information
@jtpio
Copy link
Member Author

jtpio commented Jan 4, 2023

bot please update snapshots

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Documentation snapshots updated.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Galata snapshots updated.

@jtpio jtpio closed this Jan 4, 2023
@jtpio jtpio reopened this Jan 4, 2023
@jtpio
Copy link
Member Author

jtpio commented Jan 10, 2023

Just squashed everything into 1 commit to make future (if neeed) rebases easier.

@jtpio jtpio force-pushed the update-ts branch 6 times, most recently from c0b4c78 to bd1cc00 Compare January 10, 2023 17:46
@jtpio
Copy link
Member Author

jtpio commented Jan 27, 2023

TypeScript 5 is coming: https://devblogs.microsoft.com/typescript/announcing-typescript-5-0-beta/

@jtpio
Copy link
Member Author

jtpio commented Jan 27, 2023

I won't have the bandwidth to rebase and resume this PR over the coming week. So if anyone would like to step in and take over that would be greatly appreciated, thanks!

Maybe it would be easier to start over in a new PR to avoid the rebase, and cherry-pick the changes.

@jtpio jtpio removed their assignment Jan 27, 2023
@jtpio jtpio mentioned this pull request Jan 27, 2023
Closed
jasongrout added a commit to jasongrout/jupyterlab that referenced this pull request Feb 5, 2023
@jasongrout
Fix typescript build errors
77cfc44 
Some of these fixes came from jupyterlab#13028
@jasongrout jasongrout mentioned this pull request Feb 5, 2023
Merged
@jasongrout
Copy link
Contributor

jasongrout commented Feb 5, 2023

I submitted a quick PR at #13925 to look at upgrading to TS 5.0 beta. Thanks to all the work here, that PR was much easier!

@jtpio
Copy link
Member Author

jtpio commented Feb 8, 2023

Closing in favor of #13925

@jtpio jtpio closed this Feb 8, 2023
jtpio pushed a commit to jasongrout/jupyterlab that referenced this pull request Feb 17, 2023
@jasongrout @jtpio
Fix typescript build errors
256601e 
Some of these fixes came from jupyterlab#13028
@jtpio jtpio deleted the update-ts branch February 20, 2023 14:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

maintenance pkg:application pkg:apputils pkg:attachments pkg:cell-toolbar pkg:cells pkg:celltags pkg:codeeditor pkg:codemirror pkg:completer pkg:console pkg:coreutils pkg:csvviewer pkg:debugger pkg:docmanager pkg:docprovider pkg:docregistry pkg:documentsearch pkg:extensionmanager pkg:filebrowser pkg:fileeditor pkg:help pkg:htmlviewer pkg:hub pkg:imageviewer pkg:inspector pkg:javascript pkg:json pkg:launcher pkg:logconsole pkg:lsp pkg:mainmenu pkg:markdownviewer pkg:mathjax2 pkg:notebook pkg:observables pkg:outputarea pkg:pdf pkg:property-inspector pkg:rendermime pkg:running pkg:services pkg:settingeditor pkg:settingregistry pkg:shared-models pkg:shortcuts pkg:statedb pkg:statusbar pkg:terminal pkg:themes pkg:toc pkg:tooltip pkg:translation pkg:ui-components pkg:vega tag:Examples tag:Testing

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jtpio @fcollonval @jasongrout