Skip to content

Unbump the major version of rendermime-interfaces #12581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jtpio merged 3 commits into from
May 17, 2022
Merged

Unbump the major version of rendermime-interfaces #12581

jtpio merged 3 commits into from
May 17, 2022

Conversation

@fcollonval
Copy link
Member

@fcollonval fcollonval commented May 13, 2022

References

As discussed at JupyterLab meeting

Code changes

Unbump @jupyterlab/rendermime-interfaces to 3.8.0 to keep some space for minor releases.

Make LabIcon and DocumentRegistry extends those interfaces to reduce possible future breakage.

User-facing changes

N/A

Backwards-incompatible changes

N/A

@jupyterlab-probot
Copy link

jupyterlab-probot bot commented May 13, 2022

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added this to the 4.0 milestone May 13, 2022
@fcollonval fcollonval marked this pull request as ready for review May 15, 2022 14:31
jtpio
jtpio approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 4cbca6c into jupyterlab:master May 17, 2022
@fcollonval fcollonval deleted the maintenance/unbump-rendermime-interfaces branch May 17, 2022 08:44
@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2022

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 13797 <- [14072 - 14182 - 14502] -> 15192 3296 <- [3424 - 3454 - 3501] -> 4348
expected 13701 <- [14000 - 14261 - 14678] -> 15603 3345 <- [3460 - 3491 - 3547] -> 4006
Mean relative change -0.5% ± 0.8% -1.1% ± 0.9%
switch-from
chromium
actual 615 <- [650 - 677 - 738] -> 884 491 <- [517 - 528 - 542] -> 728
expected 609 <- [648 - 667 - 682] -> 861 487 <- [516 - 532 - 549] -> 727
Mean relative change 4.7% ± 2.5% -1.9% ± 2.7%
switch-to
chromium
actual 343 <- [450 - 460 - 473] -> 512 776 <- [817 - 831 - 852] -> 1132
expected 394 <- [413 - 451 - 466] -> 517 251 <- [819 - 836 - 898] -> 1217
Mean relative change 3.2% ± 2.0% -1.5% ± 3.6%
close
chromium
actual 1096 <- [1122 - 1138 - 1170] -> 1296 556 <- [581 - 597 - 624] -> 717
expected 1090 <- [1118 - 1136 - 1158] -> 1282 558 <- [586 - 609 - 627] -> 746
Mean relative change 0.8% ± 0.9% -1.5% ± 1.8%

Changes are computed with expected as reference.

@jtpio jtpio mentioned this pull request May 19, 2022
Merged
5 tasks
@jtpio jtpio mentioned this pull request Nov 23, 2022
Open
@jtpio jtpio mentioned this pull request Dec 22, 2022
Closed
@echarles echarles mentioned this pull request Dec 22, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jtpio jtpio jtpio approved these changes

Assignees

@fcollonval fcollonval

Labels

maintenance pkg:application pkg:apputils pkg:attachments pkg:docregistry pkg:javascript pkg:json pkg:mathjax2 pkg:outputarea pkg:pdf pkg:rendermime pkg:translation pkg:ui-components pkg:vega tag:Examples

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@fcollonval @jtpio