Skip to content

Stop creating search provider for status #12564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
afshin merged 1 commit into from
May 19, 2022
Merged

Stop creating search provider for status #12564

afshin merged 1 commit into from
May 19, 2022

Conversation

@fcollonval
Copy link
Member

@fcollonval fcollonval commented May 12, 2022

References

Seen when working on #12554

Code changes

Add new method hasProvider to avoid generating search provider when only availability status is needed

User-facing changes

N/A

Backwards-incompatible changes

N/A

@jupyterlab-probot
Copy link

jupyterlab-probot bot commented May 12, 2022

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added this to the 4.0 milestone May 12, 2022
@fcollonval fcollonval marked this pull request as ready for review May 12, 2022 10:09
@trungleduc
Copy link
Member

trungleduc commented May 18, 2022

Thanks @fcollonval, LGTM

@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2022

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 11141 <- [11264 - 11336 - 11491] -> 11819 2925 <- [2998 - 3020 - 3043] -> 3154
expected 11125 <- [11227 - 11301 - 11380] -> 11718 2951 <- [3008 - 3030 - 3052] -> 3108
Mean relative change 0.5% ± 0.3% -0.2% ± 0.3%
switch-from
chromium
actual 506 <- [547 - 555 - 566] -> 612 462 <- [602 - 613 - 629] -> 667
expected 515 <- [541 - 554 - 564] -> 607 464 <- [601 - 612 - 624] -> 649
Mean relative change 0.4% ± 0.8% 0.8% ± 1.3%
switch-to
chromium
actual 349 <- [370 - 393 - 404] -> 424 662 <- [679 - 690 - 699] -> 738
expected 345 <- [361 - 388 - 402] -> 437 653 <- [678 - 686 - 701] -> 725
Mean relative change 1.1% ± 1.6% 0.2% ± 0.6%
close
chromium
actual 946 <- [966 - 978 - 989] -> 1033 492 <- [532 - 543 - 551] -> 568
expected 939 <- [966 - 982 - 994] -> 1027 492 <- [522 - 539 - 548] -> 568
Mean relative change -0.2% ± 0.5% 1.0% ± 0.8%

Changes are computed with expected as reference.

@afshin afshin merged commit 9cfad42 into jupyterlab:master May 19, 2022
@fcollonval fcollonval mentioned this pull request May 19, 2022
Closed
@fcollonval fcollonval deleted the fix/searchprovider-optimization branch May 19, 2022 06:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@trungleduc trungleduc trungleduc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fcollonval fcollonval

Labels

enhancement pkg:documentsearch

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@fcollonval @trungleduc @afshin