Skip to content

Handle missing preferredPath from the page config #12521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
echarles merged 1 commit into from
May 4, 2022
Merged

Handle missing preferredPath from the page config #12521

echarles merged 1 commit into from
May 4, 2022

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented May 3, 2022

References

Fixes #12297 (review)

This allows alternative lab-based applications like JupyterLite to not have to provide a preferredPath in the page config, since this might not be relevant in all cases.

Code changes

Handle the case where preferredPath is missing from the page config.

User-facing changes

Should be none for most users.

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

jupyterlab-probot bot commented May 3, 2022

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@jtpio jtpio requested a review from echarles May 3, 2022 20:22
@jtpio jtpio added this to the 3.4.x milestone May 3, 2022
@jtpio jtpio added bug and removed pkg:filebrowser labels May 3, 2022
@jtpio jtpio mentioned this pull request May 3, 2022
Merged
5 tasks
echarles
echarles approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Failing UI regression Extension Manager › Search is not relevant. Thx @jtpio

@echarles echarles merged commit 496bf99 into jupyterlab:master May 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 13861 <- [14149 - 14278 - 14350] -> 14769 2566 <- [2684 - 2716 - 2746] -> 2975
expected 13845 <- [14114 - 14207 - 14306] -> 14538 2522 <- [2688 - 2721 - 2747] -> 2837
Mean relative change 0.5% ± 0.3% 0.2% ± 0.6%
switch-from
chromium
actual 565 <- [607 - 621 - 639] -> 787 424 <- [445 - 456 - 475] -> 622
expected 560 <- [603 - 613 - 626] -> 670 414 <- [444 - 452 - 461] -> 481
Mean relative change 2.8% ± 1.5% 6.0% ± 2.6%
switch-to
chromium
actual 345 <- [402 - 423 - 457] -> 513 274 <- [292 - 300 - 310] -> 365
expected 381 <- [404 - 445 - 452] -> 478 266 <- [288 - 295 - 303] -> 317
Mean relative change 0.1% ± 2.0% 2.6% ± 1.3%
close
chromium
actual 1058 <- [1125 - 1175 - 1207] -> 1246 470 <- [487 - 502 - 537] -> 585
expected 1060 <- [1078 - 1086 - 1097] -> 1147 463 <- [484 - 490 - 502] -> 527
Mean relative change 6.7% ± 1.0% 4.0% ± 1.3%

Changes are computed with expected as reference.

@jtpio jtpio deleted the preferred-path branch May 4, 2022 06:36
@jtpio
Copy link
Member Author

jtpio commented May 4, 2022

@meeseeksdev please backport to 3.4.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request May 4, 2022
@echarles @meeseeksmachine
Backport PR jupyterlab#12521: Handle missing preferredPath from the…
edb9bf2 
… page config
@meeseeksmachine meeseeksmachine mentioned this pull request May 4, 2022
Merged
jtpio pushed a commit that referenced this pull request May 4, 2022
@meeseeksmachine @echarles
Backport PR #12521: Handle missing preferredPath from the page conf…
767a2da 
…ig (#12522)

Co-authored-by: Eric Charles <eric@datalayer.io>
@jtpio jtpio mentioned this pull request May 4, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@echarles echarles echarles approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jtpio jtpio

Labels

bug

Projects

None yet

Milestone

3.4.x

Development

Successfully merging this pull request may close these issues.

2 participants

@jtpio @echarles