Skip to content

Rename registerFactory to addFactory in IToolbarWidgetRegistry #12513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fcollonval merged 2 commits into from
May 13, 2022
Merged

Rename registerFactory to addFactory in IToolbarWidgetRegistry #12513

fcollonval merged 2 commits into from
May 13, 2022

Conversation

@fcollonval
Copy link
Member

@fcollonval fcollonval commented May 3, 2022

References

Code changes

Rename registerFactory to addFactory in IToolbarWidgetRegistry
add is more homogeneous with the application API

The old name has been marked as deprecated

User-facing changes

N/A

Backwards-incompatible changes

N/A

@jupyterlab-probot
Copy link

jupyterlab-probot bot commented May 3, 2022

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added api-change A change that should be accompanied by a major version increase maintenance deprecation labels May 3, 2022
@fcollonval fcollonval added this to the 4.0 milestone May 3, 2022
@jtpio
Copy link
Member

jtpio commented May 4, 2022

Thanks!

Let's add that to the extension migration guide?

@fcollonval
Copy link
Member Author

fcollonval commented May 4, 2022

Let's add that to the extension migration guide?

👍 thanks for the review

jtpio
jtpio approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a small conflict on docs/source/extension/extension_migration.rst now, but otherwise looks good 👍

Thanks!

fcollonval and others added 2 commits May 13, 2022 08:44
@fcollonval fcollonval merged commit d5d5fb9 into jupyterlab:master May 13, 2022
@fcollonval fcollonval deleted the ft/api-naming branch May 13, 2022 07:57
@jtpio jtpio mentioned this pull request May 19, 2022
Merged
5 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jtpio jtpio jtpio approved these changes

Assignees

@fcollonval fcollonval

Labels

api-change A change that should be accompanied by a major version increase deprecation documentation maintenance pkg:apputils pkg:csvviewer pkg:filebrowser pkg:htmlviewer pkg:notebook

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@fcollonval @jtpio